Change in coreboot[master]: mb/google/herobrine: Transition BOARD_HEROBRINE to BOARD_HEROBRINE_REV0
Attention is currently required from: Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60284 )
Change subject: mb/google/herobrine: Transition BOARD_HEROBRINE to BOARD_HEROBRINE_REV0 ......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/60284/comment/360e195d_203c8b45 PS2, Line 50: default "Herobrine_Rev0" if BOARD_GOOGLE_HEROBRINE_REV0
nit: I feel like this should still be "Herobrine" because it is used to construct the FWID, which ma […]
Done
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/60284/comment/48e272e4_accc792e PS2, Line 75: /* BOARD_GOOGLE_HEROBRINE */
nit: This comment is going to be more confusing than helpful once you add more boards.
Ok, removed the comment.
-
Shelley Chen (Code Review)