Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85797?usp=email )
Change subject: mb/asus/p8x7x-series: Streamline DT PCIe configs ......................................................................
mb/asus/p8x7x-series: Streamline DT PCIe configs
All variants in this family have PCIe root port 1 enabled. Turn it on in devicetree.cb and remove lines in overridetree.cb for devices that remain off.
TEST=Timeless binaries did not change across entire family.
Change-Id: I4feb88a78f72952bed049505073aed00d2120df3 Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p8x7x-series/devicetree.cb M src/mainboard/asus/p8x7x-series/variants/p8c_ws/overridetree.cb M src/mainboard/asus/p8x7x-series/variants/p8h77-v/overridetree.cb M src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb M src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/overridetree.cb 5 files changed, 1 insertion(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/85797/1
diff --git a/src/mainboard/asus/p8x7x-series/devicetree.cb b/src/mainboard/asus/p8x7x-series/devicetree.cb index e9b97bc..7719344f 100644 --- a/src/mainboard/asus/p8x7x-series/devicetree.cb +++ b/src/mainboard/asus/p8x7x-series/devicetree.cb @@ -37,7 +37,7 @@ device ref ehci2 on end device ref hda on end
- device ref pcie_rp1 off end + device ref pcie_rp1 on end # PCIe x4 slot, by various names device ref pcie_rp2 off end device ref pcie_rp3 off end device ref pcie_rp4 off end diff --git a/src/mainboard/asus/p8x7x-series/variants/p8c_ws/overridetree.cb b/src/mainboard/asus/p8x7x-series/variants/p8c_ws/overridetree.cb index 1e8d807..c0d38b6 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8c_ws/overridetree.cb +++ b/src/mainboard/asus/p8x7x-series/variants/p8c_ws/overridetree.cb @@ -24,13 +24,9 @@ { 1, 0, 6 } }" device ref pcie_rp1 on end # PCIEX16_4 (electrical x4) - device ref pcie_rp2 off end - device ref pcie_rp3 off end - device ref pcie_rp4 off end device ref pcie_rp5 on end # PCIEX1_1 device ref pcie_rp6 on end # 82574 GbE #1 device ref pcie_rp7 on end # 82574 GbE #2 - device ref pcie_rp8 off end device ref pci_bridge on end device ref lpc on chip superio/nuvoton/nct6776 diff --git a/src/mainboard/asus/p8x7x-series/variants/p8h77-v/overridetree.cb b/src/mainboard/asus/p8x7x-series/variants/p8h77-v/overridetree.cb index 1389304..f1decba 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8h77-v/overridetree.cb +++ b/src/mainboard/asus/p8x7x-series/variants/p8h77-v/overridetree.cb @@ -22,9 +22,6 @@ }" register "gen1_dec" = "0x000c0291" device ref pcie_rp1 on end # PCIEX16_2 (electrical x4) - device ref pcie_rp2 off end - device ref pcie_rp3 off end - device ref pcie_rp4 off end device ref pcie_rp5 on end # AR8161 GbE NIC device ref pcie_rp6 on end # ASM1083 PCI Bridge device ref pcie_rp7 on end # PCIEX1_1 diff --git a/src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb b/src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb index 50aed1b..c88b260 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb +++ b/src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb @@ -23,16 +23,12 @@ }"
device ref pcie_rp1 on end # PCIe x4 slot - device ref pcie_rp2 off end - device ref pcie_rp3 off end - device ref pcie_rp4 off end device ref pcie_rp5 on end # PCIe x1 slot device ref pcie_rp6 on # RTL8111F GbE NIC subsystemid 0x1849 0x1e1a device pci 00.0 on end # make onboard end device ref pcie_rp7 on end # PCI slot via ASM1083 - device ref pcie_rp8 off end device ref lpc on chip superio/nuvoton/nct6779d device pnp 2e.1 off end # Parallel diff --git a/src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/overridetree.cb b/src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/overridetree.cb index 66bc5bb..4d8124a 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/overridetree.cb +++ b/src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/overridetree.cb @@ -24,9 +24,6 @@ register "gen1_dec" = "0x000c0291"
device ref pcie_rp1 on end # PCIEX16_2 (electrical x4) - device ref pcie_rp2 off end - device ref pcie_rp3 off end - device ref pcie_rp4 off end device ref pcie_rp5 on end # RTL8111 GbE NIC device ref pcie_rp6 on end # ASM1083 PCI Bridge device ref pcie_rp7 on end # PCIEX1_1
-
Keith Hui (Code Review)