Attention is currently required from: Eran Mitrani, Matt DeVillier, Paul Menzel, Tarun Tuli.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74885?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/rex/var/rex0: add HID over SPI ACPI driver
......................................................................
Patch Set 17:
(1 comment)
File src/mainboard/google/rex/variants/rex0/include/variant/acpi/hid_spi_elan.asl:
https://review.coreboot.org/c/coreboot/+/74885/comment/e0f867e5_715227a3 :
PS17, Line 56: (LEqual(Arg0,ToUUID("6E2AC436-0FC
please use ASL2.0 syntax
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74885?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id51d385ce350cef23da4184b044c74569f4dd3f0
Gerrit-Change-Number: 74885
Gerrit-PatchSet: 17
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 12 Jun 2023 18:00:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment