Attention is currently required from: David Wu, Alan Huang.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59576 )
Change subject: mb/google/brya/var/brask: Set PL and PsysPL
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/brya/variants/brask/ramstage.c:
https://review.coreboot.org/c/coreboot/+/59576/comment/09326dbe_3551884f
PS2, Line 41: 13.52A
This looks weird to me. The max current of the typec is 5A. How could this be larger than 5A? IIUC, the typec data should be coming from the EC. The psys_config below is only for the barrel jack.
https://review.coreboot.org/c/coreboot/+/59576/comment/cd8aaae5_62090d2d
PS2, Line 41: sholud
should
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59576
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9261902b8c892d0b866f326b24988039c1d30b56
Gerrit-Change-Number: 59576
Gerrit-PatchSet: 2
Gerrit-Owner: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Hou-hsun Lee
hou-hsun.lee@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 29 Nov 2021 02:33:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment