Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Arthur Heymans.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63953 )
Change subject: soc/intel/cmn/blk/pmc: API to inform PMC about PCI enumeration done
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63953/comment/5acd9095_fa67b902
PS3, Line 7: soc/intel/cmn/blk/pmc: API to inform PMC about PCI enumeration done
Please make it a statement by adding a verb in imperative mood:
Add API …
https://review.coreboot.org/c/coreboot/+/63953/comment/75ceab01_df8952aa
PS3, Line 10:
Who is going to use this API?
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/63953/comment/651630d1_3d965a6f
PS3, Line 799: printk(BIOS_ERR, "PMC: Failed sending PCI Enumeration Done Command\n");
What are the consequences, and what should be done in this case?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63953
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77d428f9501feaccab8bb431090d10ce8d3af9b2
Gerrit-Change-Number: 63953
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 03 May 2022 07:14:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment