Attention is currently required from: Sean Rhodes, Andy Pont, Paul Menzel, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58343 )
Change subject: ec/starlabs: Add standardised ITE EC support ......................................................................
Patch Set 30:
(7 comments)
File src/ec/starlabs/merlin/ec.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133033): https://review.coreboot.org/c/coreboot/+/58343/comment/ce9060db_54e4bc24 PS30, Line 89: ARRAY_SIZE(kbl_timeout), code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133033): https://review.coreboot.org/c/coreboot/+/58343/comment/91cb9c1f_c68e8442 PS30, Line 90: 0); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133033): https://review.coreboot.org/c/coreboot/+/58343/comment/641aa36f_ef439853 PS30, Line 90: 0); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133033): https://review.coreboot.org/c/coreboot/+/58343/comment/0c8f2b6e_4be45667 PS30, Line 208: 2); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133033): https://review.coreboot.org/c/coreboot/+/58343/comment/8433c93d_260a2d8e PS30, Line 208: 2); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133033): https://review.coreboot.org/c/coreboot/+/58343/comment/8c7f62a8_c3f190c8 PS30, Line 213: 0); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133033): https://review.coreboot.org/c/coreboot/+/58343/comment/523c1a9a_e368cf55 PS30, Line 213: 0); please, no space before tabs
-
build bot (Jenkins) (Code Review)