Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74388 )
Change subject: soc/intel/cmn/cse: Make `cse_get_fpt_partition_info()` function static ......................................................................
soc/intel/cmn/cse: Make `cse_get_fpt_partition_info()` function static
The patch makes `cse_get_fpt_partition_info()` AP local/static as all the references to this function are in local to the cse_lite.c file.
BUG=b:273661726 TEST=Able to build and boot google/marasov with this code change.
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: Ie50453946c8abe55c29e9001263f0264a73c8fac Reviewed-on: https://review.coreboot.org/c/coreboot/+/74388 Reviewed-by: Kangheui Won khwon@chromium.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Sridhar Siricilla sridhar.siricilla@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kapil Porwal kapilporwal@google.com --- M src/soc/intel/common/block/cse/cse_lite.c M src/soc/intel/common/block/include/intelblocks/cse.h 2 files changed, 24 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Sridhar Siricilla: Looks good to me, approved Kangheui Won: Looks good to me, approved Kapil Porwal: Looks good to me, approved
diff --git a/src/soc/intel/common/block/cse/cse_lite.c b/src/soc/intel/common/block/cse/cse_lite.c index 4cc4f51..d6c8347 100644 --- a/src/soc/intel/common/block/cse/cse_lite.c +++ b/src/soc/intel/common/block/cse/cse_lite.c @@ -1220,7 +1220,8 @@ return CB_SUCCESS; }
-enum cb_err cse_get_fpt_partition_info(enum fpt_partition_id id, struct fw_version_resp *resp) +static enum cb_err cse_get_fpt_partition_info(enum fpt_partition_id id, + struct fw_version_resp *resp) { if (vboot_recovery_mode_enabled()) { printk(BIOS_WARNING, diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h index f3a7f83..c893846 100644 --- a/src/soc/intel/common/block/include/intelblocks/cse.h +++ b/src/soc/intel/common/block/include/intelblocks/cse.h @@ -561,10 +561,4 @@ */ enum cb_err cse_get_fw_feature_state(uint32_t *feature_state);
-/* - * The function sends a HECI command to get the partition information of the shared ID. - * The retrieved partition is stored in the memory pointed to by the resp pointer. - * The function returns 0 on success and < 0 on failure. - */ -enum cb_err cse_get_fpt_partition_info(enum fpt_partition_id id, struct fw_version_resp *resp); #endif // SOC_INTEL_COMMON_CSE_H