Change in coreboot[master]: mb/asus/am1i-a/buildOpts.c: choose the 1600 MHz RAM frequency

[Mike Banon (Code Review)]

Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40533 )

Change subject: mb/asus/am1i-a/buildOpts.c: choose the 1600 MHz RAM frequency
......................................................................

mb/asus/am1i-a/buildOpts.c: choose the 1600 MHz RAM frequency

Together with the "AMD_XMP" changes, now this board with Crucial
BLT8G3D1869DT1TX0 sticks could run at 1600 MHz CL8 (8-8-9-23) speeds.
Earlier only 1333 MHz CL9 (9-9-10-27) has been possible with coreboot.

tRP in "CL-tRCD-tRP-tRAS" gets set 1 point higher by AGESA because of
Errata 638. See more info in a BKDG for AMD Family 16h Models 00h-0Fh.

Signed-off-by: Mike Banon 
Change-Id: I192096a8756a9985395ae8e9c8abf6ca0405c2bb
---
M src/mainboard/asus/am1i-a/buildOpts.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40533/1

diff --git a/src/mainboard/asus/am1i-a/buildOpts.c b/src/mainboard/asus/am1i-a/buildOpts.c
index 48a9fe9..51f46de 100644
--- a/src/mainboard/asus/am1i-a/buildOpts.c
+++ b/src/mainboard/asus/am1i-a/buildOpts.c
@@ -116,7 +116,7 @@
 #define BLDCFG_ONLINE_SPARE                       FALSE
 #define BLDCFG_BANK_SWIZZLE                       TRUE
 #define BLDCFG_TIMING_MODE_SELECT                 TIMING_MODE_AUTO
-#define BLDCFG_MEMORY_CLOCK_SELECT                DDR1333_FREQUENCY
+#define BLDCFG_MEMORY_CLOCK_SELECT                DDR1600_FREQUENCY
 #define BLDCFG_DQS_TRAINING_CONTROL               TRUE
 #define BLDCFG_IGNORE_SPD_CHECKSUM                TRUE
 #define BLDCFG_USE_BURST_MODE                     FALSE

[Mike Banon (Code Review)]

Mike Banon has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/40533 )

Change subject: mb/asus/am1i-a/buildOpts.c: choose the 1600 MHz RAM frequency
......................................................................

mb/asus/am1i-a/buildOpts.c: choose the 1600 MHz RAM frequency

Together with the "AMD_XMP" changes, now this board with Crucial
BLT8G3D1869DT1TX0 sticks could run at 1600 MHz CL8 (8-8-9-23) speeds.
Earlier only 1333 MHz CL9 (9-9-10-27) has been possible with coreboot.

1866 MHz CL9 is impossible on f16kb without northbridge overclocking.
tRP in "CL-tRCD-tRP-tRAS" gets set 1 point higher by AGESA because of
Errata 638. See more info in a BKDG for AMD Family 16h Models 00h-0Fh.

Signed-off-by: Mike Banon 
Change-Id: I192096a8756a9985395ae8e9c8abf6ca0405c2bb
---
M src/mainboard/asus/am1i-a/buildOpts.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/40533/2

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40533 )

Change subject: mb/asus/am1i-a/buildOpts.c: choose the 1600 MHz RAM frequency
......................................................................

Patch Set 2:

Vendor's firmware supports XMP via "D.O.C.P." and runs on either 1866 MHz or 1600 MHz.

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40533 )

Change subject: mb/asus/am1i-a/buildOpts.c: choose the 1600 MHz RAM frequency
......................................................................

Patch Set 2:

Turned out this 1600 MHz works on AM1I-A only if one BLT8G3D1869DT1TX0 stick is installed (to a second slot of course). If I put a second stick - it switches to 1333 MHz (with better timings) for the same coreboot build. Luckily I already know the AGESA place to dig into, hope it'll indeed work and I could resolve it soon.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40533 )

Change subject: mb/asus/am1i-a/buildOpts.c: choose the 1600 MHz RAM frequency
......................................................................

Patch Set 2: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40533 )

Change subject: mb/asus/am1i-a/buildOpts.c: choose the 1600 MHz RAM frequency
......................................................................

Patch Set 2:
> Patch Set 2:
>
> Vendor's firmware supports XMP via "D.O.C.P." and runs on either 1866 MHz or 1600 MHz.

From [1]:
> DOCP (Direct Over Clock Profile), is from ASUS for AMD motherboards and came as the motherboard
> makers didn't want to pay royalties to Intel to implement XMP on AMD motherboards. It effectively
> uses the DRAM XMP profile to set up data rates and comparative timings on the AMD motherboards for a
> variety of data rates.

[1]: https://forums.tomshardware.com/threads/what-does-xmp-docp-eocp-mean.2789837...

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40533 )

Change subject: mb/asus/am1i-a/buildOpts.c: choose the 1600 MHz RAM frequency
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/40533/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40533/2//COMMIT_MSG@11 
PS2, Line 11: Earlier only 1333 MHz CL9 (9-9-10-27) has been possible with coreboot.
Please update the commit message that it only works with one DIMM in the second slot.

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40533 )

Change subject: mb/asus/am1i-a/buildOpts.c: choose the 1600 MHz RAM frequency
......................................................................

Patch Set 2:

is this tested on hardware?

[Mike Banon (Code Review)]

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40533 )

Change subject: mb/asus/am1i-a/buildOpts.c: choose the 1600 MHz RAM frequency
......................................................................

Patch Set 2:

(1 comment)
> Patch Set 2:
>
> is this tested on hardware?

Yes, and I test all these RAM-related changes on my hardware before submitting them.

https://review.coreboot.org/c/coreboot/+/40533/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/40533/2//COMMIT_MSG@11 
PS2, Line 11: Earlier only 1333 MHz CL9 (9-9-10-27) has been possible with coreboot.
> Please update the commit message that it only works with one DIMM in the second slot.

Perhaps I'd try fixing it for two DIMMs first: really hope that a tiny change at ./src/vendorcode/amd/agesa/f16kb/Proc/Mem/Ps/KB/mpUkb3.c will be enough. There I'm going to some limit values from 1333 to 1600 while looking at its' f15tn's relative ./agesa/f15tn/Proc/Mem/Ps/TN/mpUtn3.c (two DIMMs are working fine on 1600MHz and even 1866MHz at f15tn platform).

[Mike Banon (Code Review)]

Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/40533 )

Change subject: mb/asus/am1i-a/buildOpts.c: choose the 1600 MHz RAM frequency
......................................................................

Abandoned

Superseded by CB:44461 and CB:44462