Change in coreboot[master]: src/vendorcode/amd/fsp/picasso: Add HDMI 2.0 diable setting section o...
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Chris Wang, Patrick Huang, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52544 )
Change subject: src/vendorcode/amd/fsp/picasso: Add HDMI 2.0 diable setting section of FspmUpd.h ......................................................................
Patch Set 7: Code-Review+2
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52544/comment/82bb1d54_a40392fd PS3, Line 7: diable
yes, their is a token to disable HDMI 2. […]
Right, sorry, I should have been more clear. It's just got a typo - it should be "diSable".
https://review.coreboot.org/c/coreboot/+/52544/comment/8ba09fd6_4689701a PS3, Line 9: for customized project
got it, already remove it
Done
https://review.coreboot.org/c/coreboot/+/52544/comment/9f8fdef7_1a903ca9 PS3, Line 13: system integrated table
yes, will update in fspmpcdinit
Ack
Patchset:
PS7: Looks good except for the typo in the commit message. You can just edit that in gerrit without losing the +2.
File src/vendorcode/amd/fsp/picasso/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/52544/comment/834696c4_56afc678 PS7, Line 67: UnusedUpdSpace1
this one seems to be defined and used in fsp, so i'd add that one in a patch before this one
I'll take care of that in a follow-on patch.
File src/vendorcode/amd/fsp/picasso/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/52544/comment/a5009c86_72a3771b PS3, Line 67: UnusedUpdSpace1;
correct, also need to update the "unused"definition to sync Matt's commit?
I'll talk to Matt about it and fix it in a follow-on patch.
https://review.coreboot.org/c/coreboot/+/52544/comment/a8a261b3_ae3df6f1 PS3, Line 71: hdmi2_disable3
Maybe name these as: […]
No longer needed. Thanks.
-
Martin Roth (Code Review)