Attention is currently required from: Martin Roth, Paul Menzel, Stefan Reinauer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56213 )
Change subject: payloads: FILO: Hook up autoboot options
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3:
Should I also hook up the autoboot delay value? (Later on, the path and delay might also be read fro […]
Your call.
File payloads/external/FILO/Kconfig:
https://review.coreboot.org/c/coreboot/+/56213/comment/a3d13372_334c5867
PS3, Line 29: hda1
This is FILO’s default. […]
I find it generally hard to predict what people actually need. Is there a
chance at all that somebody would leave the default? If so, sure, let's
change it.
https://review.coreboot.org/c/coreboot/+/56213/comment/6a9beae0_a45294b9
PS3, Line 30: help
Maybe add a line that these are examples?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56213
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id167e9a144bf466da87469108002672b299b702a
Gerrit-Change-Number: 56213
Gerrit-PatchSet: 3
Gerrit-Owner: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Wed, 14 Jul 2021 16:10:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment