Attention is currently required from: Nico Huber, Wonkyu Kim, Kyösti Mälkki.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60213 )
Change subject: [WIP] cpu/x86/lapic: Fix choice X2APIC_ONLY
......................................................................
Patch Set 2:
(1 comment)
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/60213/comment/588e32a6_7b2456bd
PS2, Line 652: lapic_send_ipi(LAPIC_INT_ASSERT | LAPIC_DM_SMI, lapicid());
We can do that. There is also stop_this_cpu(), like mentioned before. […]
Sorry let me be more clear. I mean, if a delay or fence, etc. is required so that no further "real" instructions are executed, maybe we should wrap that whole sequence up into its own function, so we don't need the delay loop/fence/whatever sprinkled around.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60213
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78070ae91e78c11c3e3aa225e5673d4667d6f7bb
Gerrit-Change-Number: 60213
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 23 Dec 2021 19:54:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment