Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31987 )
Change subject: sb/intel/{i82801g/i/j,bd82x6x}: Make use of generic set_subsystem() ......................................................................
Patch Set 1:
(1 comment)
Arthur, Patrick; can you verify this on hardware?
Subrata; Yes, submitting inside branch out-of-order is never good idea...
https://review.coreboot.org/#/c/31987/1/src/southbridge/intel/bd82x6x/pci.c File src/southbridge/intel/bd82x6x/pci.c:
https://review.coreboot.org/#/c/31987/1/src/southbridge/intel/bd82x6x/pci.c@... PS1, Line 70: This all seems copy-paste error or code that was forgotten on some refactoring. It's pointless to test dev->on_mainboard in code that runs for the integrated PCI-to-PCI device 0:1e.0, and this seems redundant with PCI subsystem calling the same ops->set_subsystem.