Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/18011 )
Change subject: mainboard/lenovo/t430: Add Thinkpad T430 support ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/#/c/18011/11/src/mainboard/lenovo/t430/romstage.... File src/mainboard/lenovo/t430/romstage.c:
PS11, Line 36: 0x10001fe0
Did you check that these bits are not already set? How can you
no
PS11, Line 36: PCH_DISABLE_ALWAYS
The name already says that this doesn't belong into mainboard code, sigh. B
I kept the reserved values only
Line 39: /* FIXME: used T530 values here */
Can't this be decoded easily with autoport?
Autoport wasn't able to generate useful values, that's why t530 values are used