Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Martin Roth, Tim Van Patten.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75700?usp=email )
Change subject: mb/google/myst: Update PCIE_RST_L drive
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/75700/comment/28e34365_b85bf93f :
PS4, Line 55: PAD_NFO(GPIO_27, PCIE_RST1_L, LOW),
PCIE_RST1_L isn't connected to anything, so there's no point in driving it high. […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75700?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f7a548a33eb18327139f033d7c0d6a1843f1639
Gerrit-Change-Number: 75700
Gerrit-PatchSet: 4
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 12:37:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment