Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/21605 )
Change subject: soc/intel/common/block: Update LPC lib
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/21605/2/src/soc/intel/common/block/lpc/lpc_l...
File src/soc/intel/common/block/lpc/lpc_lib.c:
https://review.coreboot.org/#/c/21605/2/src/soc/intel/common/block/lpc/lpc_l...
PS2, Line 253: soc_get_gen_io_dec_config(dev, gen_io_dec);
A weak will be needed here? Or any dependency for this function?
--
To view, visit
https://review.coreboot.org/21605
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9359765f7293210044b411db49163df0418070a
Gerrit-Change-Number: 21605
Gerrit-PatchSet: 2
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 19 Sep 2017 22:05:42 +0000
Gerrit-HasComments: Yes