Attention is currently required from: Tim Wawrzynczak, Angel Pons, Michael Niewöhner, Alexander Couzens, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51332 )
Change subject: soc/intel/skylake: detect if IGD is present
......................................................................
Patch Set 7:
(2 comments)
File src/soc/intel/skylake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/51332/comment/00863a65_87d20f9e
PS7, Line 119: SA_DEVFN_IGD
These types are not compatible, I think you need `SA_DEV_IGD`.
File src/soc/intel/skylake/romstage/systemagent.c:
https://review.coreboot.org/c/coreboot/+/51332/comment/e3df3ff5_cfad8db6
PS7, Line 33: SA_DEVFN_IGD
Same here, `SA_DEV_IGD`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51332
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife6e6157db0df772b48a9cb95a0f1494ae21c250
Gerrit-Change-Number: 51332
Gerrit-PatchSet: 7
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Patrick Rudolph
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 19 Mar 2021 11:48:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment