Change in coreboot[master]: mb/google/dedede/var/drawcia: Audio support for ALC5682 codec and MX9...

[Chen Wisley (Code Review)]

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42928 )

Change subject: mb/google/dedede/var/drawcia: Audio support for ALC5682 codec and MX98360A
......................................................................

mb/google/dedede/var/drawcia: Audio support for ALC5682 codec and MX98360A

drawcia support ALC5682 codec and MX98360A spk amp

BUG=b:158202026
TEST=FW_NAME=drawcia emerge-dedede coreboot chromeos-bootimage

Change-Id: If271f11f10a85ade6f61ff8c25bfafeb67a69af6
Signed-off-by: Wisley Chen 
---
M src/mainboard/google/dedede/Kconfig.name
M src/mainboard/google/dedede/variants/drawcia/overridetree.cb
2 files changed, 22 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/42928/1

diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name
index 4e2a450..5db6675 100644
--- a/src/mainboard/google/dedede/Kconfig.name
+++ b/src/mainboard/google/dedede/Kconfig.name
@@ -8,6 +8,7 @@
    select BOARD_GOOGLE_BASEBOARD_DEDEDE
    select BASEBOARD_DEDEDE_LAPTOP
    select BOARD_ROMSIZE_KB_32768
+	select DRIVERS_GENERIC_MAX98357A

config BOARD_GOOGLE_DRAWCIA
    bool "Drawcia"
diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
index 3b67510..38690f7 100644
--- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
@@ -61,5 +61,26 @@
    			device i2c 10 on end
    		end
    	end # I2C 2
+		device pci 19.0 on
+			chip drivers/i2c/generic
+				register "hid" = ""10EC5682""
+				register "name" = ""RT58""
+				register "desc" = ""Headset Codec""
+				register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D16)"
+				# Set the jd_src to RT5668_JD1 for jack detection
+				register "property_count" = "1"
+				register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER"
+				register "property_list[0].name" = ""realtek,jd-src""
+				register "property_list[0].integer" = "1"
+				device i2c 1a on end
+			end
+		end #I2C 4
+		device pci 1f.3 on
+			chip drivers/generic/max98357a
+				register "hid" = ""MX98360A""
+				register "sdmode_gpio" =  "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D17)"
+				device generic 0 on end
+			end
+		end # Intel HDA
    end
 end

Change in coreboot[master]: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX9836...

[Yong Zhi (Code Review)]

Yong Zhi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42928 )

Change subject: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX98360A spk amp)
......................................................................

Patch Set 2:

This change is ready for review.

Change in coreboot[master]: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX9836...

[Yong Zhi (Code Review)]

Yong Zhi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42928 )

Change subject: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX98360A spk amp)
......................................................................

Patch Set 2:

Can you confirm are there two DMICs or just single DMIC module? the baseboard has two DMIC enabled.

Change in coreboot[master]: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX9836...

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42928 )

Change subject: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX98360A spk amp)
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42928/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/42928/2/src/mainboard/google/dedede... 
PS2, Line 11: DRIVERS_GENERIC_MAX98357A
Enable it under BOARD_GOOGLE_DRAWCIA. The CL needs to be rebased since we added BOARD_GOOGLE_DRAWCIA_LEGACY which also needs to enable this config.

Change in coreboot[master]: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX9836...

[Chen Wisley (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Maulik V Vaghela, Justin TerAvest, Paul Menzel, Marco Chen, Aamir Bohra,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42928

to look at the new patch set (#3).

Change subject: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX98360A spk amp)
......................................................................

mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX98360A spk amp)

Select the drivers for ALC5682 codec and MX98360A spk amp

BUG=b:158202026
TEST=FW_NAME=drawcia emerge-dedede coreboot chromeos-bootimage

Change-Id: If271f11f10a85ade6f61ff8c25bfafeb67a69af6
Signed-off-by: Wisley Chen 
---
M src/mainboard/google/dedede/Kconfig.name
M src/mainboard/google/dedede/variants/drawcia/overridetree.cb
2 files changed, 23 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/42928/3

Change in coreboot[master]: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX9836...

[Chen Wisley (Code Review)]

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42928 )

Change subject: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX98360A spk amp)
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42928/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/42928/2/src/mainboard/google/dedede... 
PS2, Line 11: DRIVERS_GENERIC_MAX98357A
> Enable it under BOARD_GOOGLE_DRAWCIA. […]

Done, thanks

Change in coreboot[master]: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX9836...

[Henry Sun (Code Review)]

Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42928 )

Change subject: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX98360A spk amp)
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42928/3/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/42928/3/src/mainboard/google/dedede... 
PS3, Line 22:         
wrong indentation

https://review.coreboot.org/c/coreboot/+/42928/3/src/mainboard/google/dedede... 
PS3, Line 29:         
wrong indentation

Change in coreboot[master]: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX9836...

[Chen Wisley (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Maulik V Vaghela, Justin TerAvest, Paul Menzel, Marco Chen, Aamir Bohra,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42928

to look at the new patch set (#4).

Change subject: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX98360A spk amp)
......................................................................

mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX98360A spk amp)

Select the drivers for ALC5682 codec and MX98360A spk amp

BUG=b:158202026
TEST=FW_NAME=drawcia emerge-dedede coreboot chromeos-bootimage

Change-Id: If271f11f10a85ade6f61ff8c25bfafeb67a69af6
Signed-off-by: Wisley Chen 
---
M src/mainboard/google/dedede/Kconfig.name
M src/mainboard/google/dedede/variants/drawcia/overridetree.cb
2 files changed, 23 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/42928/4

Change in coreboot[master]: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX9836...

[Chen Wisley (Code Review)]

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42928 )

Change subject: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX98360A spk amp)
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42928/3/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/42928/3/src/mainboard/google/dedede... 
PS3, Line 22:
> wrong indentation

Done

https://review.coreboot.org/c/coreboot/+/42928/3/src/mainboard/google/dedede... 
PS3, Line 29:
> wrong indentation

Done

Change in coreboot[master]: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX9836...

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42928 )

Change subject: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX98360A spk amp)
......................................................................

Patch Set 4: Code-Review+2

Change in coreboot[master]: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX9836...

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42928 )

Change subject: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX98360A spk amp)
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/42928/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42928/1//COMMIT_MSG@7 
PS1, Line 7: mb/google/dedede/var/drawcia: Audio support for ALC5682 codec and MX98360A
> > Add audio support (ALC5682 codec, MX98360A spk amp)

Done

https://review.coreboot.org/c/coreboot/+/42928/1//COMMIT_MSG@9 
PS1, Line 9: drawcia support ALC5682 codec and MX98360A spk amp
> Select the drivers for ….

Done

Change in coreboot[master]: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX9836...

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42928 )

Change subject: mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX98360A spk amp)
......................................................................

mb/google/dedede/var/drawcia:Add audio support (ALC5682 codec, MX98360A spk amp)

Select the drivers for ALC5682 codec and MX98360A spk amp

BUG=b:158202026
TEST=FW_NAME=drawcia emerge-dedede coreboot chromeos-bootimage

Change-Id: If271f11f10a85ade6f61ff8c25bfafeb67a69af6
Signed-off-by: Wisley Chen 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42928
Tested-by: build bot (Jenkins) 
Reviewed-by: Karthik Ramasubramanian 
---
M src/mainboard/google/dedede/Kconfig.name
M src/mainboard/google/dedede/variants/drawcia/overridetree.cb
2 files changed, 23 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Karthik Ramasubramanian: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/Kconfig.name b/src/mainboard/google/dedede/Kconfig.name
index 893a457..071ae5b 100644
--- a/src/mainboard/google/dedede/Kconfig.name
+++ b/src/mainboard/google/dedede/Kconfig.name
@@ -19,12 +19,14 @@
    bool "Drawcia"
    select BOARD_GOOGLE_BASEBOARD_DEDEDE
    select BASEBOARD_DEDEDE_LAPTOP
+	select DRIVERS_GENERIC_MAX98357A

config BOARD_GOOGLE_DRAWCIA_LEGACY
    bool "Drawcia (Legacy)"
    select BOARD_GOOGLE_BASEBOARD_DEDEDE
    select BASEBOARD_DEDEDE_LAPTOP
    select BOARD_ROMSIZE_KB_32768
+	select DRIVERS_GENERIC_MAX98357A

config BOARD_GOOGLE_WADDLEDOO
    bool "Waddledoo"
diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
index 3b67510..38690f7 100644
--- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb
@@ -61,5 +61,26 @@
    			device i2c 10 on end
    		end
    	end # I2C 2
+		device pci 19.0 on
+			chip drivers/i2c/generic
+				register "hid" = ""10EC5682""
+				register "name" = ""RT58""
+				register "desc" = ""Headset Codec""
+				register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D16)"
+				# Set the jd_src to RT5668_JD1 for jack detection
+				register "property_count" = "1"
+				register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER"
+				register "property_list[0].name" = ""realtek,jd-src""
+				register "property_list[0].integer" = "1"
+				device i2c 1a on end
+			end
+		end #I2C 4
+		device pci 1f.3 on
+			chip drivers/generic/max98357a
+				register "hid" = ""MX98360A""
+				register "sdmode_gpio" =  "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D17)"
+				device generic 0 on end
+			end
+		end # Intel HDA
    end
 end