Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Curtis Chen, Brandon Breitenstein.
Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57139 )
Change subject: soc/intel/common/tcss: Optimize USB-C DP flow and code structure
......................................................................
Patch Set 21:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57139/comment/8491af68_363cd10e
PS20, Line 8:
Please describe the problem first.
Done
https://review.coreboot.org/c/coreboot/+/57139/comment/b88b6be2_e769b3d3
PS20, Line 11:
Please paste the new log messages, which should be shown now, and say, what exact device you tested […]
Done
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/57139/comment/f4837c34_02530779
PS19, Line 313: get_mux_info
If `wait_for_hpd()` is successful, does it not guarantee that the MUX is configured in DP mode? Is t […]
Agree that if `wait_for_hpd()` is successful, it guarantee that the mux is configured in DP. Removed the additional check.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57139
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7e6dd952d3183ecb76de6d4887ee573ef89bb50
Gerrit-Change-Number: 57139
Gerrit-PatchSet: 21
Gerrit-Owner: Derek Huang
derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Curtis Chen
curtis.chen@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Curtis Chen
curtis.chen@intel.com
Gerrit-Attention: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Attention: Curtis Chen
curtis.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 01 Oct 2021 09:58:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment