Attention is currently required from: Chen Wisley.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59349 )
Change subject: [TEST] mb/google/brya/var/redrix: exchange i2c port for touchscreen/cr50
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/redrix/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59349/comment/50d528a3_4caebd2b
PS2, Line 32: HW_PHASE
suggestion: I would consider renaming this to e.g.
```
field TPM_I2C_BUS 42 42
option I2C_BUS_1 0
option I2C_BUS_3 1
end
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59349
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f3a1a20d98cd4cbfa6fc7cc31cb688761f9f763
Gerrit-Change-Number: 59349
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Attention: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Comment-Date: Tue, 16 Nov 2021 17:49:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment