Attention is currently required from: Angel Pons, Dinesh Gehlot, Elyes Haouas, Paul Menzel, Thomas Heijligen.
Nico Huber has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/libgfxinit/+/81522?usp=email )
Change subject: gma display_probing: Make new TGL ports available
......................................................................
Patch Set 7:
(1 comment)
File common/hw-gfx-gma-display_probing.adb:
https://review.coreboot.org/c/libgfxinit/+/81522/comment/afe19fa6_ddd8c6b5?u... :
PS7, Line 38: function Sibling_Port (Port : Port_Type) return Port_Type is
Hmmmmm, wait. […]
Yep, the new naming makes this more obvious. The TC ports can also be implemented
as DP and HDMI at the same time. So in theory, can suffer from the same issues.
(though, I have to admit that I only saw this with 10y old ThinkPad docks where
you really can physically connect two competing displays at the same time)
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/81522?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I9d96673f931be0086536044694ecd127ba2a823d
Gerrit-Change-Number: 81522
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Dinesh Gehlot
digehlot@google.com
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 29 Aug 2024 18:31:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com