Attention is currently required from: Erin Park, Paul Menzel, Tarun Tuli.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75907?usp=email )
Change subject: soc/intel/meteorlake: Set Energy Perf Bias appropriate default value.
......................................................................
Patch Set 1:
(1 comment)
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/75907/comment/efa59081_28331ba7 :
PS1, Line 56: #define ENERGY_POLICY_BALANCE_POWERSAVE 8
Please make that a separate commit und use tabs for alignment.
+1, this file is not specific to Meteorlake. Please move it to a separate commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75907?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib716584f516a538251c022e15b3193359b794366
Gerrit-Change-Number: 75907
Gerrit-PatchSet: 1
Gerrit-Owner: Erin Park
erin.park@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Erin Park
erin.park@intel.com
Gerrit-Comment-Date: Mon, 19 Jun 2023 11:04:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment