Attention is currently required from: Forest Mittelberg, Jameson Thies.
Subrata Banik has posted comments on this change by Jameson Thies. ( https://review.coreboot.org/c/coreboot/+/84404?usp=email )
Change subject: chromeec/ec_acpi: Define ACPI devices for USB-C ports using UCSI ......................................................................
Patch Set 1:
(4 comments)
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/84404/comment/4fcd283b_699a9122?usp... : PS1, Line 169: bool ucsi_platform = google_chromeec_get_ucsi_enabled(); can we move this at line 182 ?
https://review.coreboot.org/c/coreboot/+/84404/comment/1df32eac_30e4a5da?usp... : PS1, Line 200: usb2_port = NULL; : usb3_port = NULL; : usb4_port = NULL; for these case as well ?
https://review.coreboot.org/c/coreboot/+/84404/comment/abf9e289_2055facd?usp... : PS1, Line 203: orientation_switch = NULL; : usb_role_switch = NULL; : mode_switch = NULL; : retimer_switch = NULL; can we set the default while declaring these local variables ?
https://review.coreboot.org/c/coreboot/+/84404/comment/8793a7ab_8fde4c6d?usp... : PS1, Line 230: .orientation_switch = orientation_switch, : .usb_role_switch = usb_role_switch, : .mode_switch = mode_switch, : .retimer_switch = retimer_switch, is it okay to set `NULL` to `orientation_switch` and others as per ACPI spec? or we should keep it untouched when !ucsi_platform ?