Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59746 )
Change subject: soc/mediatek/mt8195: update devapc settings ......................................................................
Patch Set 1:
(9 comments)
File src/soc/mediatek/mt8195/include/soc/devapc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134635): https://review.coreboot.org/c/coreboot/+/59746/comment/0327ef6d_a7bfb508 PS1, Line 106: #define NO_PROTECTION2 NO_PROTECTION, NO_PROTECTION Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134635): https://review.coreboot.org/c/coreboot/+/59746/comment/7f4ea517_ba4eb814 PS1, Line 107: #define NO_PROTECTION3 NO_PROTECTION2, NO_PROTECTION Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134635): https://review.coreboot.org/c/coreboot/+/59746/comment/5e0b6752_655f51fb PS1, Line 109: #define FORBIDDEN2 FORBIDDEN, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134635): https://review.coreboot.org/c/coreboot/+/59746/comment/84a3f89d_09464338 PS1, Line 113: #define FORBIDDEN10 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134635): https://review.coreboot.org/c/coreboot/+/59746/comment/00274cee_526ef157 PS1, Line 116: #define FORBIDDEN11 FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, FORBIDDEN, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134635): https://review.coreboot.org/c/coreboot/+/59746/comment/8d2a300d_f16f5baa PS1, Line 119: #define FORBIDDEN12 FORBIDDEN11, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134635): https://review.coreboot.org/c/coreboot/+/59746/comment/b8d9c8f5_a09c2d38 PS1, Line 120: #define FORBIDDEN13 FORBIDDEN12, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134635): https://review.coreboot.org/c/coreboot/+/59746/comment/af5478f4_d9bb244f PS1, Line 121: #define FORBIDDEN14 FORBIDDEN13, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134635): https://review.coreboot.org/c/coreboot/+/59746/comment/c425b250_5adb8519 PS1, Line 122: #define FORBIDDEN15 FORBIDDEN14, FORBIDDEN Macros with complex values should be enclosed in parentheses
-
build bot (Jenkins) (Code Review)