Attention is currently required from: Sean Rhodes, Michał Żygowski, Patrick Rudolph, Paul Menzel, Michał Kopeć, Krystian Hebel.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73981 )
Change subject: drivers/smmstore/ramstage.c: retry smmstore init up 5 times
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/smmstore/ramstage.c:
https://review.coreboot.org/c/coreboot/+/73981/comment/96e0dbb7_86f2b538
PS1, Line 79: } while (retry--);
I'm afraid this can't be done, even `mdelay()` should be removed from the code. […]
Maybe CB:74741 raise_io_smi() would work here. Sounds like the polling should not be hidden under drivers/smmstore. There's no retry of outb() yet, just the noop/pause part. I wonder what the argumentation was to repeat the outb() ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73981
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8929af25c4f69873bbdd835fde5cb60fc324b6ab
Gerrit-Change-Number: 73981
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Tue, 25 Apr 2023 13:05:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-MessageType: comment