[M] Change in coreboot[master]: arch/x86/include: Split msr access into separate file

[Martin Roth (Code Review)]

Attention is currently required from: Martin L Roth, Jan Dabros, Elyes Haouas.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67917 )

Change subject: arch/x86/include: Split msr access into separate file
......................................................................

Patch Set 3:

(2 comments)

Patchset:

PS3:
> will <cpu/x86/msr.h> chain-include <cpu/x86/msr_access. […]

Yes, that's the plan - both of these patches (cpuid & msr) are intended to be chain included, though they could be included separately if for some reason only the access mechanisms were needed.

File src/include/cpu/x86/msr_access.h:

https://review.coreboot.org/c/coreboot/+/67917/comment/48ec3190_ca54b1e6 
PS3, Line 30: /* The following functions require the __always_inline due to AMD
            :  * function STOP_CAR_AND_CPU that disables cache as
            :  * RAM, the cache as RAM stack can no longer be used. Called
            :  * functions must be inlined to avoid stack usage. Also, the
            :  * compiler must keep local variables register based and not
            :  * allocated them from the stack. With gcc 4.5.0, some functions
            :  * declared as inline are not being inlined. This patch forces
            :  * these functions to always be inlined by adding the qualifier
            :  * __always_inline to their declaration.
            :  */
> This comment could be rewritten a bit. It looks like it was copied from a commit message.

I agree, but this patch is a simple move.