Attention is currently required from: Kapil Porwal, Subrata Banik, Tarun Tuli.
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75714?usp=email )
Change subject: [TEST ONLY] add VPRO features control by fw config
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/rex/variants/rex0/cpulib.c:
https://review.coreboot.org/c/coreboot/+/75714/comment/02daef39_af4d7a65 :
PS1, Line 10: if(fw_config_probe(FW_CONFIG(TME, TME_DIS))) {
space required before the open parenthesis '('
Please fix.
https://review.coreboot.org/c/coreboot/+/75714/comment/589f7822_66e1cef8 :
PS1, Line 20: if(fw_config_probe(FW_CONFIG(KEYLOCKER, KEYLOCKER_DIS))) {
space required before the open parenthesis '('
Please fix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75714?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I746ba80279dc69d06ac9e06bfeae068e31d23694
Gerrit-Change-Number: 75714
Gerrit-PatchSet: 2
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 07 Jun 2023 21:26:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment