Attention is currently required from: Boris Mittelberg, Caveh Jalali, Eric Lai, Tarun Tuli, Tim Wawrzynczak.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75824?usp=email )
Change subject: ec/google/chromeec: Use mux_conn to get the right USB port
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75824/comment/90677a31_831b894a :
PS2, Line 9: get_usb_port_references
Search through the devicetree for matching USB Type-C ports, will always report the port by device t […]
check the below code in `get_usb_port_references` -
```
int group_token;
if (config->use_custom_pld)
group_token = config->custom_pld.group.token;
else
group_token = config->group.token;
if (group_token != (port_number + 1))
continue;
```
I think current PLD for Type-A port `ACPI_PLD_TYPE_A(RIGHT, RIGHT, ACPI_PLD_GROUP(1, 2))` is causing this issue. Could you please try https://review.coreboot.org/c/coreboot/+/75911 ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75824?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I058c6cc0fea6758bfaafdd163b5da2c7f75daf8a
Gerrit-Change-Number: 75824
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Mon, 19 Jun 2023 04:16:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment