Attention is currently required from: Felix Singer, Subrata Banik, Tarun Tuli.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71643?usp=email )
Change subject: soc/intel/meteorlake: Fill PCI SSID parameters
......................................................................
Patch Set 6:
(2 comments)
File src/soc/intel/meteorlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/71643/comment/6f912a77_88ba49f2 :
PS5, Line 710: *svid = dev->subsystem_vendor ? : 0x8086;
Add a newline
Acknowledged. Replaced if-else statements with ternary operator.
https://review.coreboot.org/c/coreboot/+/71643/comment/a6012882_80692284 :
PS5, Line 714: 0xFFFE
lower case
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71643?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I364c2052984b6f562bffe8f5ad7035c8b659d369
Gerrit-Change-Number: 71643
Gerrit-PatchSet: 6
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Mon, 05 Jun 2023 10:14:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-MessageType: comment