[L] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6373 driver

[Yidi Lin (Code Review)]

Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin.

Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85129?usp=email )

Change subject: soc/mediatek/mt8196: Add PMIC MT6373 driver
......................................................................

Patch Set 36:

(6 comments)

File src/soc/mediatek/common/mt6373.c:

https://review.coreboot.org/c/coreboot/+/85129/comment/4d089f60_26f6cf12?usp... :
PS36, Line 23: = NULL
not needed.

https://review.coreboot.org/c/coreboot/+/85129/comment/b1d13033_622c5fcf?usp... :
PS36, Line 57: )
remove

https://review.coreboot.org/c/coreboot/+/85129/comment/4391a800_3facf544?usp... :
PS36, Line 198: 	printk(BIOS_INFO, "%s success\n", __func__);
Why this message is needed ?

https://review.coreboot.org/c/coreboot/+/85129/comment/5d16c846_e2bc5de4?usp... :
PS36, Line 229: 0xFFFF
Is is correct ?

https://review.coreboot.org/c/coreboot/+/85129/comment/10655383_bc218a48?usp... :
PS36, Line 247: /* for N project*/
what does it mean ?

https://review.coreboot.org/c/coreboot/+/85129/comment/b4ce0b37_aa521af4?usp... :
PS36, Line 252: ERROR - Failed to initialize pmif spi
"%s: initialization failed", __func__