Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32060
Change subject: mb/google/hatch: Initialize FPMCU_PCH_BOOT1 ......................................................................
mb/google/hatch: Initialize FPMCU_PCH_BOOT1
In the latest hatch schematics, BOOT1 for the FP MCU is now connected to the AP. Configuring it to be the same as BOOT0.
BUG=b:126455006 BRANCH=None TEST=./util/abuild/abuild -p none -t google/hatch -x -a -c max
Change-Id: Ibb451983674a7d812dc562cb8addb1dc50fb155c Signed-off-by: Shelley Chen shchen@google.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/32060/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 73d6645..1328240 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -33,8 +33,8 @@ /* A8 : EMR_GARAGE_DET ==> NC */ PAD_NC(GPP_A8, NONE), /* A9 : ESPI_CLK */ - /* A10 : PEN_RESET_ODL */ - PAD_NC(GPP_A10, NONE), + /* A10 : FPMCU_PCH_BOOT1 */ + PAD_CFG_GPO(GPP_A10, 0, DEEP), /* A11 : PCH_SPI_FPMCU_CS_L */ PAD_CFG_NF(GPP_A11, NONE, DEEP, NF2), /* A12 : FPMCU_RST_ODL */
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32060 )
Change subject: mb/google/hatch: Initialize FPMCU_PCH_BOOT1 ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32060 )
Change subject: mb/google/hatch: Initialize FPMCU_PCH_BOOT1 ......................................................................
mb/google/hatch: Initialize FPMCU_PCH_BOOT1
In the latest hatch schematics, BOOT1 for the FP MCU is now connected to the AP. Configuring it to be the same as BOOT0.
BUG=b:126455006 BRANCH=None TEST=./util/abuild/abuild -p none -t google/hatch -x -a -c max
Change-Id: Ibb451983674a7d812dc562cb8addb1dc50fb155c Signed-off-by: Shelley Chen shchen@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32060 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/variants/baseboard/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 3d6be33..68bbaab 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -33,8 +33,8 @@ /* A8 : EMR_GARAGE_DET */ PAD_CFG_GPI_GPIO_DRIVER(GPP_A8, NONE, DEEP), /* A9 : ESPI_CLK */ - /* A10 : PEN_RESET_ODL */ - PAD_NC(GPP_A10, NONE), + /* A10 : FPMCU_PCH_BOOT1 */ + PAD_CFG_GPO(GPP_A10, 0, DEEP), /* A11 : PCH_SPI_FPMCU_CS_L */ PAD_CFG_NF(GPP_A11, NONE, DEEP, NF2), /* A12 : FPMCU_RST_ODL */
-
Furquan Shaikh (Code Review) -
Patrick Georgi (Code Review)
-
Shelley Chen (Code Review)