[S] Change in coreboot[master]: mb/siemens/mc_ehl2: Provide I2C timing parameter for SSDT - coreboot-gerrit

8 Nov 2022


      Attention is currently required from: Eric Lai.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69307 )
Change subject: mb/siemens/mc_ehl2: Provide I2C timing parameter for SSDT
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/siemens/mc_ehl/variants/mc_ehl2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/69307/comment/dac956bb_7bddb8f9 
PS1, Line 117: 				.scl_lcnt = 0x1f4,
...
Maybe decimal? Since i2c designware driver use the decimal.
I have used hex format to stay consistent with the siemens/mc_apl mainboards. But I can switch to decimal if you insist.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69307
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifb6019421b612133b8f25c076519bc0e7200dad8
Gerrit-Change-Number: 69307
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 08 Nov 2022 07:00:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment