Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85734?usp=email )
Change subject: soc/mediatek/mt8196: Add MT6685 Clock IC driver ......................................................................
Patch Set 6:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85734/comment/85a2435d_afc4c6a3?usp... : PS5, Line 7: adc init
Clock IC driver
Done
https://review.coreboot.org/c/coreboot/+/85734/comment/c1d766dc_f205f640?usp... : PS5, Line 8:
`'intial' may be misspelled - perhaps 'initial'?` […]
Done
https://review.coreboot.org/c/coreboot/+/85734/comment/68a727b9_7dd1b2cb?usp... : PS5, Line 9: and MT6685 ADC SW intial settings
and ADC init settings
Done
File src/soc/mediatek/common/include/soc/mt6685_adc_init.h:
PS5:
mt6685. […]
Done
File src/soc/mediatek/common/mt6685.c:
https://review.coreboot.org/c/coreboot/+/85734/comment/62243bbb_8b7ff75d?usp... : PS5, Line 38:
Please also add mt6685_{read/write}8. RTC needs both APIs.
Done
https://review.coreboot.org/c/coreboot/+/85734/comment/5980a0d3_e09a87d3?usp... : PS5, Line 39: mt6685_get_reg_value16
mt6685_read16
Done
https://review.coreboot.org/c/coreboot/+/85734/comment/23ce9720_5f059d84?usp... : PS5, Line 48: mt6685_set_reg_value16
mt6685_write16
Done
https://review.coreboot.org/c/coreboot/+/85734/comment/3df75177_7d65ad2c?usp... : PS5, Line 80: mt6685_adc_init
mt6685_init
Done