Attention is currently required from: Paul Menzel.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58191 )
Change subject: soc/qualcomm/sc7280: Enable compression of SHRM
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58191/comment/147a558f_a562c4ef
PS3, Line 15: Also, did some cleanup in this file based on comments in CB:49392.
In the future, it would be great to have this in a separate commit.
Noted. I bunched these changes together because they seemed so small to me that I didn't think that it merited a separate CL.
https://review.coreboot.org/c/coreboot/+/58191/comment/8cddf2ca_13148b95
PS3, Line 19: TEST=Make sure we can still boot to kernel on herobrine
What timing differences are there?
I see no boot time differences, actually.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58191
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaad8a8a02abe40bd01766d94ef0b61aac7671936
Gerrit-Change-Number: 58191
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Sudheer Amrabadi
samrabad@codeaurora.org
Gerrit-CC: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 14 Oct 2021 18:20:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment