[S] Change in coreboot[master]: soc/amd/picasso/soc_util: use cpuid_match - coreboot-gerrit

7 Feb 2023


      Attention is currently required from: Jason Glenesk, Matt DeVillier, Eric Lai, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72860 )
Change subject: soc/amd/picasso/soc_util: use cpuid_match
......................................................................
Patch Set 5:
(1 comment)
File src/soc/amd/picasso/soc_util.c:
https://review.coreboot.org/c/coreboot/+/72860/comment/0cd599b5_2741cc9d 
PS4, Line 97: 0xffffff00
...
CPUID_ALL_STEPPINGS_AND_BASE_MODELS_MASK? Don't know how to shorter this.
sounds good to me and i also can't think of a shorter name that still makes it clear enough what it;s doing. update the patch
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/72860
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I758f9564c08c62c747cc4f93a8d6b540a1834a62
Gerrit-Change-Number: 72860
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 07 Feb 2023 10:23:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment