Hello Nicolas Boichat,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/46581
to review the following change.
Change subject: HACK: First set pwren to 0 ......................................................................
HACK: First set pwren to 0
Maybe not 100% necessary, but should still be good practise.
BUG=b:155713214 TEST=boot asurada
Change-Id: Ib8b3366795ae876227546be393681d8ac404e51b --- M src/mainboard/google/asurada/panel_anx7625.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/46581/1
diff --git a/src/mainboard/google/asurada/panel_anx7625.c b/src/mainboard/google/asurada/panel_anx7625.c index 0145859..10aa305 100644 --- a/src/mainboard/google/asurada/panel_anx7625.c +++ b/src/mainboard/google/asurada/panel_anx7625.c @@ -18,6 +18,7 @@ gpio_output(GPIO_PP3300_PANEL, 1);
/* Turn on bridge */ + gpio_output(GPIO_MIPIBRDG_PWREN, 0); gpio_output(GPIO_MIPIBRDG_RST_L_1V8, 0); gpio_output(GPIO_MIPIBRDG_PP1000_EN, 1); gpio_output(GPIO_MIPIBRDG_PP1800_EN, 1);
Yongqiang Niu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46581 )
Change subject: HACK: First set pwren to 0 ......................................................................
Patch Set 6:
abandon
fix with patch https://chromium-review.googlesource.com/c/chromiumos/platform/depthcharge/+...
yongqiang niu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46581 )
Change subject: HACK: First set pwren to 0 ......................................................................
Abandoned