Attention is currently required from: Maulik V Vaghela.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62272 )
Change subject: soc/intel/adl: Send EOP early in the boot sequence
......................................................................
Patch Set 11:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62272/comment/7b90a144_2d2da7f4
PS11, Line 24: This also aligns with previous flow where
: FSP used to send EOP once silicon init is done and coreboot used to
: rely on FSP to send this message.
and why is this only relevant for adl and not for other platforms?
File src/soc/intel/alderlake/chip.c:
https://review.coreboot.org/c/coreboot/+/62272/comment/3ab04451_95ff8390
PS11, Line 158: Intel CSE team recommends to send EOP close to FW init (between FSP-S exit and
: * current boot sequence) to reduce message response time from CSE hence moving
: * sending EOP to earlier stage.
what about cnl,tgl? is this a general recommendation?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62272
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9401d5e36ad43cdc0dfe947aabc82528d824df9b
Gerrit-Change-Number: 62272
Gerrit-PatchSet: 11
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Comment-Date: Thu, 17 Mar 2022 21:56:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment