[M] Change in coreboot[main]: soc/intel/common/block/pmc: Add GPE1 functions

[Felix Held (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Hannah Williams, Jamie Ryu, Paul Menzel, Subrata Banik.

Felix Held has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84104?usp=email )

Change subject: soc/intel/common/block/pmc: Add GPE1 functions
......................................................................

Patch Set 28:

(1 comment)

File src/soc/intel/common/block/pmc/pmclib.c:

https://review.coreboot.org/c/coreboot/+/84104/comment/e7642486_12f3ca1d?usp... :
PS11, Line 68: /* SoC overrides for GPE1 when SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1 is enabled */
             : __weak const char *const *soc_std_gpe1_sts_array(int idx, size_t *a)
             : {
             : 	return NULL;
             : }
             : 
             : /* disable the corresponding GPE1 bits based on standard GPE0 bits */
             : __weak void soc_pmc_disable_std_gpe1(uint32_t gpe0_mask)
             : {
             : }
             : 
             : /* enable the corresponding GPE1 bits based on standard GPE0 bits */
             : __weak void soc_pmc_enable_std_gpe1(uint32_t gpe0_mask)
             : {
             : }
> Felix, build issue fixed?

the point i tried to make was that there's no need to have some weak (or regular) implementation of those 3 functions when SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1 isn't selected, since those function calls will become unreachable when SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1 isn't selected, so the compiler will just optimize out the calls and so the linker won't run into a problem due to those not bring implemented in that case. the current implementation has the advantage over the one with the weak function, that the case where SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1 is selected, but the 3 functions aren't implemented in the soc code will be caught in the build process. i'll just mark this one as resolved; don't want to cause too much delay for you