Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42372 )
Change subject: cpu/x86/smm: Clean up SMM_ASEG
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/42372/1/src/cpu/x86/smm/aseg_region...
File src/cpu/x86/smm/aseg_region.c:
https://review.coreboot.org/c/coreboot/+/42372/1/src/cpu/x86/smm/aseg_region...
PS1, Line 19: 0x20000
Use a define for that?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42372
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I519c242aa3b837f3e09fd34dee5aa4a2dc3c97ba
Gerrit-Change-Number: 42372
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 23 Jun 2020 06:01:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment