Attention is currently required from: Tim Wawrzynczak, Christian Walter, Eric Lai. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63011 )
Change subject: drivers/i2c/tpm: Add workaround for Ti50 ......................................................................
Patch Set 4:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63011/comment/09927e57_f8ed88b2 PS4, Line 7: drivers/i2c/tpm: Add workaround for Ti50 Maybe:
Work around missing board_cfg in Ti50 FW 0.15
https://review.coreboot.org/c/coreboot/+/63011/comment/a66ac3d2_f7c1bbbb PS4, Line 9: is not support board cfg I do not understand the problem. Can you please elaborate. Do you mean “dropped support for board_cfg”?
https://review.coreboot.org/c/coreboot/+/63011/comment/06a25aae_3c1668d7 PS4, Line 11: What is with the firmware versions inbetween?
File src/drivers/i2c/tpm/Kconfig:
https://review.coreboot.org/c/coreboot/+/63011/comment/73732329_01a40de0 PS4, Line 31: which with?
https://review.coreboot.org/c/coreboot/+/63011/comment/dec6ce99_c6c85ce6 PS4, Line 31: Board has a Ti50 I2C workaround which Ti50 FW under 0.15 Please elaborate.
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/63011/comment/4ab22856_36eb4fe2 PS4, Line 503: /* Ti50 FW version under 0.15 doesn't support board cfg … anymore?
https://review.coreboot.org/c/coreboot/+/63011/comment/bd0f19f6_5ec7d646 PS4, Line 505: */ Belongs on the line above.
-
Paul Menzel (Code Review)