Attention is currently required from: Caveh Jalali, Dinesh Gehlot, Eric Herrmann, Forest Mittelberg, Kapil Porwal, Karthik Ramasubramanian, Keith Short, Nick Vaccaro, Rishika Raj, Shelly Chang, Subrata Banik.
Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83735?usp=email )
Change subject: ec/google/chromeec: Add is_battery_present()
......................................................................
Patch Set 7:
(1 comment)
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/83735/comment/1e45fbed_9905af4b?usp... :
PS4, Line 433: google_chromeec_is_battery_present
My preference is to wait until we make the decision. […]
Dynamically updating the PL4 is for Battery connected but not charged beyond critical threshold(1% with adaptor and 4% without adaptor) case which will be handled separately.
This is only for no battery scenario where it is ok for PL4 to be less and not updated later after system boots up
In earlier cases - - https://review.coreboot.org/c/coreboot/+/83406 (abandoned patch) we were trying to boot up with psys PL value changes which was not working for 45watts sku2 for no battery use case also
So this solution is for no battery scenario only .(sorry few more details -in parallel, I am working for a clean solution for dead battery scenario - I have looped in hardware team, PNP team and probably reach out to OS team to write into MSR 0x601 - once the battery is charged beyond critical threshold - I will keep updating on partner bug - which will remain open till we have a solution for dead battery case also)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83735?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie49ed8f6d8b0fa59ec0e7b06efea9cac4d253957
Gerrit-Change-Number: 83735
Gerrit-PatchSet: 7
Gerrit-Owner: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Herrmann
eherrmann@google.com
Gerrit-Reviewer: Forest Mittelberg
bmbm@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Keith Short
keithshort@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-CC: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Eric Herrmann
eherrmann@google.com
Gerrit-Attention: Keith Short
keithshort@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Forest Mittelberg
bmbm@google.com
Gerrit-Attention: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Comment-Date: Sat, 03 Aug 2024 14:07:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com