Attention is currently required from: Arthur Heymans, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63004 )
Change subject: Move common EFI and FSP definitions to commonlib ......................................................................
Patch Set 2:
(5 comments)
File src/commonlib/include/commonlib/fsp_info_header.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144481): https://review.coreboot.org/c/coreboot/+/63004/comment/7a795648_888d98d6 PS2, Line 37: struct FSP_EXTENTED_HEADER { 'EXTENTED' may be misspelled - perhaps 'EXTENDED'?
File src/commonlib/include/commonlib/uefi_types.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144481): https://review.coreboot.org/c/coreboot/+/63004/comment/e2814643_a71ce939 PS2, Line 9: #define SIGNATURE_32(A, B, C, D) (SIGNATURE_16 (A, B) | (SIGNATURE_16 (C, D) << 16)) space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144481): https://review.coreboot.org/c/coreboot/+/63004/comment/39aa7952_dfd1589d PS2, Line 9: #define SIGNATURE_32(A, B, C, D) (SIGNATURE_16 (A, B) | (SIGNATURE_16 (C, D) << 16)) space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144481): https://review.coreboot.org/c/coreboot/+/63004/comment/1e163d07_62ba0a7c PS2, Line 13: #define EFI_FVH_SIGNATURE SIGNATURE_32 ('_', 'F', 'V', 'H') space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144481): https://review.coreboot.org/c/coreboot/+/63004/comment/eed2abfa_57e5e396 PS2, Line 13: #define EFI_FVH_SIGNATURE SIGNATURE_32 ('_', 'F', 'V', 'H') Macros with complex values should be enclosed in parentheses
-
build bot (Jenkins) (Code Review)