Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37887 )
Change subject: soc/intel/tigerlake: Add ACPI support for CNVi
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37887/10/src/soc/intel/tigerlake/ac...
File src/soc/intel/tigerlake/acpi/cnvi.asl:
https://review.coreboot.org/c/coreboot/+/37887/10/src/soc/intel/tigerlake/ac...
PS10, Line 75: _RST
Ack
ACK for a question? I don't understand the answer.
https://review.coreboot.org/c/coreboot/+/37887/10/src/soc/intel/tigerlake/ac...
PS10, Line 136: AOLD
There is a UPD which corresponds to CnviBToffload, when I checked, we needed this for that.
I don't understand why this ASL method is required for a FSP UPD. Can you please provide more details?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37887
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66091374f8ebcb06457296252c9a8924734a7fa5
Gerrit-Change-Number: 37887
Gerrit-PatchSet: 14
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.corp-partner.google.com
Gerrit-CC: caveh jalali
caveh@chromium.org
Gerrit-Comment-Date: Wed, 29 Jan 2020 00:24:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment