Attention is currently required from: Angel Pons, Johnny Lin, Morgan Jang, Patrick Rudolph.
Hello Angel Pons, Johnny Lin, Morgan Jang, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85318?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed: Code-Review+2 by Angel Pons, Verified+1 by build bot (Jenkins)
Change subject: mb/ocp/tiogapass: Implement mainboard_dimm_slot_exists ......................................................................
mb/ocp/tiogapass: Implement mainboard_dimm_slot_exists
The board has 24 slots for DDR4 ECC RDIMMs and it has 2 CPU sockets, where each is connected to 12 DIMMs. Every socket supports up to 6 channels, thus every channel is connected to 2 DIMMs.
Implement mainboard_dimm_slot_exists accordingly to advertise all slots as SMBIOS type 17.
TEST: Found all installed DIMMs advertised through SMBIOS on ocp/tiogapass.
Change-Id: I31cb4a89aa11258ac04eb69a0e9c86f258280484 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/mainboard/ocp/tiogapass/romstage.c 1 file changed, 17 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/85318/8