Attention is currently required from: Paul Menzel, Tim Wawrzynczak. Gwendal Grignou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59608 )
Change subject: driver/i2c: Add sx9360 driver ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59608/comment/2fd49d2d_50b6729b PS3, Line 12: Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml
That’s not yet in Linus’ master branch?
It was presumptive: the patch has been submitted only: https://patchwork.kernel.org/project/linux-iio/patch/20211213024057.3824985-...
File src/drivers/i2c/sx9360/sx9360.c:
PS2:
Good point. Please mention in the commit message, what code you took as base.
Done
https://review.coreboot.org/c/coreboot/+/59608/comment/21e6de1f_0524d99d PS2, Line 15: REGISTER
It is unused, I should have removed it when copied the code from sx9324.
Done
https://review.coreboot.org/c/coreboot/+/59608/comment/307790c7_3b505d2a PS2, Line 61: describe
described
Done
-
Gwendal Grignou (Code Review)