Attention is currently required from: Patrick Rudolph. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/59309 )
Change subject: soc/intel/../thermal: Drop `ltt_value` local variable ......................................................................
soc/intel/../thermal: Drop `ltt_value` local variable
Using the `GET_LTT_VALUE` macro directly instead of 'ltt_value' local variable.
Change-Id: I791766bf2a78fa30dbba8cf4ad8a50e44f0e73ed Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/common/block/thermal/thermal.c 1 file changed, 2 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/59309/1
diff --git a/src/soc/intel/common/block/thermal/thermal.c b/src/soc/intel/common/block/thermal/thermal.c index f886995..6211f35 100644 --- a/src/soc/intel/common/block/thermal/thermal.c +++ b/src/soc/intel/common/block/thermal/thermal.c @@ -11,6 +11,7 @@ #define MAX_TRIP_TEMP 205 /* This is the safest default Trip Temp value */ #define DEFAULT_TRIP_TEMP 50 +/* Trip Point Temp = (LTT / 2 - 50 degree C) */ #define GET_LTT_VALUE(x) (((x) + 50) * (2))
static uint8_t get_thermal_trip_temp(void) @@ -24,7 +25,6 @@ /* PCH Low Temp Threshold (LTT) */ static uint16_t pch_get_ltt_value(struct device *dev) { - uint16_t ltt_value; uint8_t thermal_config;
thermal_config = get_thermal_trip_temp(); @@ -34,10 +34,7 @@ if (thermal_config > MAX_TRIP_TEMP) die("Input PCH temp trip is higher than allowed range!");
- /* Trip Point Temp = (LTT / 2 - 50 degree C) */ - ltt_value = GET_LTT_VALUE(thermal_config); - - return ltt_value; + return GET_LTT_VALUE(thermal_config); }
/* Enable thermal sensor power management */