Change in coreboot[master]: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER
Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER
Change-Id: I91ac4fce4bb27b763fcb4b4dfdf396b46bf103e1 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h 1 file changed, 44 insertions(+), 44 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/42920/1
diff --git a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h index 114095a..13d44c2 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h +++ b/src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h @@ -45,7 +45,7 @@ PAD_CFG_NF(GPP_A11, NONE, DEEP, NF1),
/* GPP_A12 - GPIO */ - PAD_CFG_GPO(GPP_A12, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_A12, 1, PLTRST, NONE),
/* GPP_A13 - SUSWARN# */ PAD_CFG_NF(GPP_A13, NONE, DEEP, NF1), @@ -63,7 +63,7 @@ PAD_NC(GPP_A17, NONE),
/* GPP_A18 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_A18, NONE, PLTRST, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_A18, NONE, PLTRST, OFF, DRIVER),
/* GPP_A19 - RESERVED */
@@ -80,10 +80,10 @@ PAD_NC(GPP_A23, NONE),
/* GPP_B0 - GPIO */ - PAD_CFG_GPO(GPP_B0, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_B0, 1, DEEP, NONE),
/* GPP_B1 - GPIO */ - PAD_CFG_GPO(GPP_B1, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_B1, 1, DEEP, NONE),
/* GPP_B2 - GPIO */ PAD_NC(GPP_B2, NONE), @@ -113,7 +113,7 @@ PAD_NC(GPP_B10, NONE),
/* GPP_B11 - GPIO */ - PAD_CFG_GPO(GPP_B11, 0, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_B11, 0, DEEP, NONE),
/* GPP_B12 - SLP_S0# */ PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), @@ -140,7 +140,7 @@ PAD_NC(GPP_B19, NONE),
/* GPP_B20 - GPIO */ - PAD_CFG_GPO(GPP_B20, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_B20, 1, PLTRST, NONE),
/* GPP_B21 - GPIO */ PAD_NC(GPP_B21, NONE), @@ -163,20 +163,20 @@ /* GPP_C4 - RESERVED */
/* GPP_C5 - GPIO */ - PAD_CFG_GPO(GPP_C5, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_C5, 1, DEEP, NONE),
/* GPP_C6 - RESERVED */
/* GPP_C7 - RESERVED */
/* GPP_C8 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_C8, NONE, PLTRST, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_C8, NONE, PLTRST, OFF, DRIVER),
/* GPP_C9 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_C9, NONE, PLTRST, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_C9, NONE, PLTRST, OFF, DRIVER),
/* GPP_C10 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_C10, NONE, PLTRST, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_C10, NONE, PLTRST, OFF, DRIVER),
/* GPP_C11 - GPIO */ PAD_NC(GPP_C11, NONE), @@ -221,7 +221,7 @@ PAD_NC(GPP_D0, NONE),
/* GPP_D1 - GPIO */ - PAD_CFG_GPO(GPP_D1, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_D1, 1, DEEP, NONE),
/* GPP_D2 - GPIO */ PAD_CFG_GPI_NMI(GPP_D2, 20K_PU, DEEP, EDGE_SINGLE, NONE), @@ -230,7 +230,7 @@ PAD_NC(GPP_D3, NONE),
/* GPP_D4 - GPIO */ - PAD_CFG_GPO(GPP_D4, 0, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_D4, 0, PLTRST, NONE),
/* GPP_D5 - GPIO */ PAD_NC(GPP_D5, NONE), @@ -272,19 +272,19 @@ PAD_NC(GPP_D17, NONE),
/* GPP_D18 - GPIO */ - PAD_CFG_GPO(GPP_D18, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_D18, 1, PLTRST, NONE),
/* GPP_D19 - GPIO */ - PAD_CFG_GPO(GPP_D19, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_D19, 1, PLTRST, NONE),
/* GPP_D20 - GPIO */ PAD_NC(GPP_D20, NONE),
/* GPP_D21 - GPIO */ - PAD_CFG_GPO(GPP_D21, 0, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_D21, 0, DEEP, NONE),
/* GPP_D22 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_D22, NONE, RSMRST, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_D22, NONE, RSMRST, OFF, DRIVER),
/* GPP_D23 - GPIO */ PAD_NC(GPP_D23, NONE), @@ -347,16 +347,16 @@ PAD_CFG_GPI_APIC(GPP_F5, NONE, PLTRST),
/* GPP_F6 - GPIO */ - PAD_CFG_GPO(GPP_F6, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_F6, 1, PLTRST, NONE),
/* GPP_F7 - GPIO */ - PAD_CFG_GPO(GPP_F7, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_F7, 1, PLTRST, NONE),
/* GPP_F8 - GPIO */ - PAD_CFG_GPO(GPP_F8, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_F8, 1, PLTRST, NONE),
/* GPP_F9 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_F9, NONE, PLTRST, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_F9, NONE, PLTRST, OFF, DRIVER),
/* GPP_F10 - SATA_SCLOCK */ PAD_CFG_NF(GPP_F10, NONE, DEEP, NF1), @@ -398,19 +398,19 @@ PAD_NC(GPP_F22, NONE),
/* GPP_F23 - GPIO */ - PAD_CFG_GPO(GPP_F23, 0, RSMRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_F23, 0, RSMRST, NONE),
/* GPP_G0 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_G0, NONE, DEEP, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_G0, NONE, DEEP, OFF, DRIVER),
/* GPP_G1 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_G1, NONE, DEEP, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_G1, NONE, DEEP, OFF, DRIVER),
/* GPP_G2 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_G2, NONE, DEEP, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_G2, NONE, DEEP, OFF, DRIVER),
/* GPP_G3 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_G3, NONE, DEEP, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_G3, NONE, DEEP, OFF, DRIVER),
/* GPP_G4 - GPIO */ PAD_NC(GPP_G4, NONE), @@ -437,19 +437,19 @@ PAD_NC(GPP_G11, NONE),
/* GPP_G12 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_G12, NONE, PLTRST, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_G12, NONE, PLTRST, OFF, DRIVER),
/* GPP_G13 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_G13, NONE, PLTRST, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_G13, NONE, PLTRST, OFF, DRIVER),
/* GPP_G14 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_G14, NONE, PLTRST, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_G14, NONE, PLTRST, OFF, DRIVER),
/* GPP_G15 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_G15, NONE, PLTRST, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_G15, NONE, PLTRST, OFF, DRIVER),
/* GPP_G16 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_G16, NONE, PLTRST, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_G16, NONE, PLTRST, OFF, DRIVER),
/* GPP_G17 - GPIO */ PAD_NC(GPP_G17, NONE), @@ -473,34 +473,34 @@ PAD_NC(GPP_G23, NONE),
/* GPP_H0 - GPIO */ - PAD_CFG_GPO(GPP_H0, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_H0, 1, DEEP, NONE),
/* GPP_H1 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_H1, NONE, PLTRST, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_H1, NONE, PLTRST, OFF, DRIVER),
/* GPP_H2 - GPIO */ - PAD_CFG_GPO(GPP_H2, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_H2, 1, DEEP, NONE),
/* GPP_H3 - SRCCLKREQ9# */ PAD_CFG_NF(GPP_H3, NONE, DEEP, NF1),
/* GPP_H4 - GPIO */ - PAD_CFG_GPI_TRIG_OWN(GPP_H4, NONE, PLTRST, OFF, ACPI), + PAD_CFG_GPI_TRIG_OWN(GPP_H4, NONE, PLTRST, OFF, DRIVER),
/* GPP_H5 - GPIO */ - PAD_CFG_GPO(GPP_H5, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_H5, 1, PLTRST, NONE),
/* GPP_H6 - GPIO */ - PAD_CFG_GPO(GPP_H6, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_H6, 1, PLTRST, NONE),
/* GPP_H7 - GPIO */ - PAD_CFG_GPO(GPP_H7, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_H7, 1, PLTRST, NONE),
/* GPP_H8 - GPIO */ - PAD_CFG_GPO(GPP_H8, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_H8, 1, PLTRST, NONE),
/* GPP_H9 - GPIO */ - PAD_CFG_GPO(GPP_H9, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_H9, 1, PLTRST, NONE),
/* GPP_H10 - SML2CLK */ PAD_CFG_NF(GPP_H10, NONE, DEEP, NF1), @@ -530,19 +530,19 @@ PAD_NC(GPP_H18, NONE),
/* GPP_H19 - GPIO */ - PAD_CFG_GPO(GPP_H19, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_H19, 1, PLTRST, NONE),
/* GPP_H20 - GPIO */ - PAD_CFG_GPO(GPP_H20, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_H20, 1, PLTRST, NONE),
/* GPP_H21 - GPIO */ - PAD_CFG_GPO(GPP_H21, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_H21, 1, PLTRST, NONE),
/* GPP_H22 - GPIO */ - PAD_CFG_GPO(GPP_H22, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_H22, 1, PLTRST, NONE),
/* GPP_H23 - GPIO */ - PAD_CFG_GPO(GPP_H23, 1, PLTRST), + PAD_CFG_GPO_GPIO_DRIVER(GPP_H23, 1, PLTRST, NONE),
/* GPD0 - GPIO */ PAD_NC(GPD0, NONE),
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42920/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42920/3//COMMIT_MSG@8 PS3, Line 8: Could you please elaborate?
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42920
to look at the new patch set (#4).
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER
Set the Host Software Pad Ownership to DRIVER mode for the corresponding pads that are not configured for SCI, SMI, NMI, IOxAPIC interrupts, as well as for the x11ssm-f variant.
Change-Id: I91ac4fce4bb27b763fcb4b4dfdf396b46bf103e1 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h 1 file changed, 44 insertions(+), 44 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/42920/4
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42920
to look at the new patch set (#5).
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER
Set the Host Software Pad Ownership to DRIVER mode for the corresponding pads that are not configured for SCI, SMI, NMI, IOxAPIC interrupts, as well as for the x11ssm-f variant.
Change-Id: I91ac4fce4bb27b763fcb4b4dfdf396b46bf103e1 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h 1 file changed, 44 insertions(+), 44 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/42920/5
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42920/6/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42920/6/src/mainboard/supermicro/x1... PS6, Line 66: PAD_CFG_GPI_TRIG_OWN PAD_CFG_GPI_INT? for the others, too
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42920
to look at the new patch set (#7).
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER
Set the Host Software Pad Ownership to DRIVER mode for the corresponding pads that are not configured for SCI, SMI, NMI, IOxAPIC interrupts, as well as for the x11ssm-f variant. In addition to this, use a shorter PAD_CFG_GPI_INT() macro instead of PAD_CFG_GPO_GPIO_DRIVER() to set DRIVER mode.
Change-Id: I91ac4fce4bb27b763fcb4b4dfdf396b46bf103e1 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h 2 files changed, 61 insertions(+), 61 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/42920/7
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42920/6/src/mainboard/supermicro/x1... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42920/6/src/mainboard/supermicro/x1... PS6, Line 66: PAD_CFG_GPI_TRIG_OWN
PAD_CFG_GPI_INT? for the others, too
Done
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42920
to look at the new patch set (#8).
Change subject: supermicro/x11-lga1151/gpio: set Host SW Ownership to DRIVER ......................................................................
supermicro/x11-lga1151/gpio: set Host SW Ownership to DRIVER
x11ssh-tf: Set the Host Software Pad Ownership to DRIVER mode for the corresponding pads that are not configured for SCI, SMI, NMI, IOxAPIC interrupts, as well as for the x11ssm-f variant.
x11ssh-tf, x11ssm-f: Use a shorter PAD_CFG_GPI_INT() macro instead of PAD_CFG_GPI_TRIG_OWN() to set DRIVER mode.
Change-Id: I91ac4fce4bb27b763fcb4b4dfdf396b46bf103e1 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h 2 files changed, 61 insertions(+), 61 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/42920/8
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42920
to look at the new patch set (#9).
Change subject: supermicro/x11-lga1151/gpio: set Host SW Ownership to DRIVER ......................................................................
supermicro/x11-lga1151/gpio: set Host SW Ownership to DRIVER
x11ssh-tf: Set the Host Software Pad Ownership to DRIVER mode for the corresponding pads that are not configured for SCI, SMI, NMI, IOxAPIC interrupts, as well as for the x11ssm-f variant.
x11ssh-tf, x11ssm-f: Use a shorter PAD_CFG_GPI_INT() macro instead of PAD_CFG_GPI_TRIG_OWN() to set DRIVER mode.
Change-Id: I91ac4fce4bb27b763fcb4b4dfdf396b46bf103e1 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h 2 files changed, 61 insertions(+), 61 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/42920/9
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: supermicro/x11-lga1151/gpio: set Host SW Ownership to DRIVER ......................................................................
Patch Set 9: Code-Review+2
Hello build bot (Jenkins), Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42920
to look at the new patch set (#10).
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER
x11ssh-tf: Set the Host Software Pad Ownership to DRIVER mode for the corresponding pads to set Driver Interrupt mode - one APIC interrupt for all available GPIO [1], as well as for the x11ssm-f variant.
x11ssh-tf, x11ssm-f: Use a shorter PAD_CFG_GPI_INT() macro instead of PAD_CFG_GPI_TRIG_OWN() to set DRIVER mode.
[1] Intel document #549921
Change-Id: I91ac4fce4bb27b763fcb4b4dfdf396b46bf103e1 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h M src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/include/variant/gpio.h 2 files changed, 61 insertions(+), 61 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/42920/10
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 48: PAD_CFG_GPO_GPIO_DRIVER DRIVER refers to interrupts and I'm not sure if this macro is correct. Furquan Shaikh says that this doesn't make sense. Pad host ownership has meaning only when the pad is configured as input. What do you think about this?
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 48: PAD_CFG_GPO_GPIO_DRIVER
DRIVER refers to interrupts and I'm not sure if this macro is correct. […]
you mean the macro itself but not it's use here, don't you?
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 48: PAD_CFG_GPO_GPIO_DRIVER
you mean the macro itself but not it's use here, don't you?
Hmm, tbh I'm a bit confused...
doc#332691-003EN says that the ownership bit decides which interrupt bits get masked. Comments in fsp/Include/GpioConfig.h confirm that. Those bits are only relevant for input/interrupt pads.
fsp/Include/GpioConfig.h also states that ownership must be set to driver if the OS driver shall be able to control the pad, but an ACPI entry (GpioIo/GpioInt) is required.
I have no idea if "control the pad" translates to "change direction" or only "change state if set as output".
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
Patch Set 10: Code-Review-1
(1 comment)
Without schematics, there's no way to be sure this is correct.
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 48: PAD_CFG_GPO_GPIO_DRIVER
Hmm, tbh I'm a bit confused... […]
I don't see any `GpioIo` nor `GpioInt` in ACPI that would be used by this mainboard.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 48: PAD_CFG_GPO_GPIO_DRIVER
I don't see any `GpioIo` nor `GpioInt` in ACPI that would be used by this mainboard.
Yes, that is correct. I just wonder if we should a) set what the vendor set (what this here does) or b) do what we _think_ is right. And since we have no schematics I would go for a) even though we know it doesn't do anything.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
Patch Set 10: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 48: PAD_CFG_GPO_GPIO_DRIVER
I don't see any `GpioIo` nor `GpioInt` in ACPI that would be used by this mainboard. […]
Woops, vendor value is without ownership... sry for confusion
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
Patch Set 10:
(18 comments)
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 83: PAD_CFG_GPO_GPIO_DRIVER(GPP_B0, 1, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 86: PAD_CFG_GPO_GPIO_DRIVER(GPP_B1, 1, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 116: PAD_CFG_GPO_GPIO_DRIVER(GPP_B11, 0, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 143: PAD_CFG_GPO_GPIO_DRIVER(GPP_B20, 1, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 166: PAD_CFG_GPO_GPIO_DRIVER(GPP_C5, 1, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 224: PAD_CFG_GPO_GPIO_DRIVER(GPP_D1, 1, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 233: PAD_CFG_GPO_GPIO_DRIVER(GPP_D4, 0, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 275: PAD_CFG_GPO_GPIO_DRIVER(GPP_D18, 1, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 278: PAD_CFG_GPO_GPIO_DRIVER(GPP_D19, 1, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 284: PAD_CFG_GPO_GPIO_DRIVER(GPP_D21, 0, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 350: PAD_CFG_GPO_GPIO_DRIVER(GPP_F6, 1, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 353: PAD_CFG_GPO_GPIO_DRIVER(GPP_F7, 1, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 356: PAD_CFG_GPO_GPIO_DRIVER(GPP_F8, 1, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 401: PAD_CFG_GPO_GPIO_DRIVER(GPP_F23, 0, RSMRST, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 476: PAD_CFG_GPO_GPIO_DRIVER(GPP_H0, 1, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 482: PAD_CFG_GPO_GPIO_DRIVER(GPP_H2, 1, DEEP, NONE), same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 487: /* GPP_H4 - GPIO */ : PAD_CFG_GPI_INT(GPP_H4, NONE, PLTRST, OFF), : : /* GPP_H5 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H5, 1, PLTRST, NONE), : : /* GPP_H6 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H6, 1, PLTRST, NONE), : : /* GPP_H7 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H7, 1, PLTRST, NONE), : : /* GPP_H8 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H8, 1, PLTRST, NONE), : : /* GPP_H9 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H9, 1, PLTRST, NONE), : same here; don't change vendor values, since we don't have schematics
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 532: GPP_H19 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H19, 1, PLTRST, NONE), : : /* GPP_H20 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H20, 1, PLTRST, NONE), : : /* GPP_H21 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H21, 1, PLTRST, NONE), : : /* GPP_H22 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H22, 1, PLTRST, NONE), : : /* GPP_H23 - GPIO */ : PAD_CFG_GPO_GPIO_DRIVER(GPP_H23, 1, PLTRST, NONE), same here; don't change vendor values, since we don't have schematics
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42920 )
Change subject: mb/supermicro/x11ssh-tf: set Host SW Pad Ownership to DRIVER ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/42920/10/src/mainboard/supermicro/x... PS10, Line 48: PAD_CFG_GPO_GPIO_DRIVER
Woops, vendor value is without ownership... […]
I suggest to abandon this patch, but not change PAD_CFG_GPO_GPIO_DRIVER to PAD_CFG_GPO in all files now. I think, we shouldn't to resolve global issues in this patch. This weekend I will make a separate patch (remove PAD_CFG_GPO_GPIO_DRIVER) in which we will have a discussion about these macro. It's already used in some boards from google, intel, siemens. I believe that DRIVER mode is GPI related only and the PAD_CFG_GPO_GPIO_DRIVER macro isn't correct, however, we should be careful with such changes :)
-
Angel Pons (Code Review) -
Maxim Polyakov (Code Review)
-
Michael Niewöhner (Code Review)
-
Paul Menzel (Code Review)