Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21839 )
Change subject: [TEST]drivers/net/r8168: Add customized nic led function ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c File src/drivers/net/r8168.c:
https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c@224 PS2, Line 224: #if better avoid preprocessor and just do "if (!IS_ENABLED(...)) return;"
https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c@224 PS2, Line 224: defined IS_ENABED
https://review.coreboot.org/#/c/21839/2/src/drivers/net/r8168.c@231 PS2, Line 231: CONFIG_RTL8168_CUSTOMIZED_LED please use devicetree parameters instead of Kconfig.