[XS] Change in coreboot[main]: arch/x86/include/smm: improve documentation of call_smm - coreboot-gerrit

8 Jan 2024


      Attention is currently required from: Felix Held, Jérémy Compostella.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79834?usp=email )
Change subject: arch/x86/include/smm: improve documentation of call_smm
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/arch/x86/include/smm_call.h:
https://review.coreboot.org/c/coreboot/+/79834/comment/4f5ec4cb_d560f813 :
PS1, Line 9: can then read
how about 'will then read' or 'then reads'? 'can' makes it sound optional
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79834?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3566af191492ce00a3033335ff80e01c33e98e63
Gerrit-Change-Number: 79834
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 08 Jan 2024 14:57:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment