Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add deivces settings ......................................................................
mb/google/dedede/var/magolor: Add deivces settings
Add the configuration in device tree: 1. Add HDA,sepacker codec and speaker amp setting 2. set the NC usb ports 3. Add Elan and Goodix touchscreen setting 4. Add facing camera usb setting 5. Add BT usb setting 6. Add Synaptics and Elan Touchpad setting 7. Add discrete WiFi configuration
BUG=None BRANCH=None TEST=build magolor firmware.
Change-Id: Ifc562b4a05c8955d2aec105f2f429f926ad1e702 --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 109 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/44633/1
diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb index 404024b..f04a2bd 100644 --- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb +++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb @@ -1,5 +1,10 @@ chip soc/intel/jasperlake
+ # USB Port Configuration + register "usb2_ports[4]" = "USB2_PORT_EMPTY" # Not Used + register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # Camera + register "usb3_ports[6]" = "USB3_PORT_EMPTY" # Not Used + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | @@ -9,10 +14,11 @@ #| | for TPM communication | #| | before memory is up | #| I2C0 | Trackpad | - #| I2C1 | Digitizer | + #| I2C1 | TBD | #| I2C2 | Touchscreen | #| I2C3 | Camera | #| I2C4 | Audio | + #| I2C5 | TBD | #+-------------------+---------------------------+ register "common_soc_config" = "{ .gspi[0] = { @@ -37,6 +43,107 @@ }"
device domain 0 on - device pci 15.0 on end + device pci 14.0 on + chip drivers/usb/acpi + device usb 0.0 on + chip drivers/usb/acpi + register "desc" = ""Camera"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.5 on end + end + chip drivers/usb/acpi + register "desc" = ""Integrated Bluetooth"" + register "type" = "UPC_TYPE_INTERNAL" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H19)" + device usb 2.7 on end + end + end + end + end # USB xHCI + device pci 15.0 on + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" + register "generic.wake" = "GPE0_DW0_03" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" + register "wake" = "GPE0_DW0_03" + register "probed" = "1" + device i2c 15 on end + end + end # I2C 0 + device pci 15.2 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "2" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "generic.enable_delay_ms" = "12" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 0x5d on end + end + chip drivers/i2c/hid + register "generic.hid" = ""ELAN9050"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" + register "generic.reset_delay_ms" = "20" + register "generic.reset_off_delay_ms" = "2" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)" + register "generic.stop_delay_ms" = "280" + register "generic.stop_off_delay_ms" = "2" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "generic.enable_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 10 on end + end + end # I2C 2 + device pci 19.0 on + chip drivers/i2c/generic + register "hid" = ""10EC5682"" + register "name" = ""RT58"" + register "desc" = ""Realtek RT5682"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D16)" + register "property_count" = "1" + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""realtek,jd-src"" + register "property_list[0].integer" = "1" + device i2c 1a on end + end + chip drivers/i2c/generic + register "hid" = ""10EC1015"" + register "desc" = ""Realtek SPK AMP L"" + register "uid" = "0" + device i2c 28 on end + end + chip drivers/i2c/generic + register "hid" = ""10EC1015"" + register "desc" = ""Realtek SPK AMP R"" + register "uid" = "1" + device i2c 29 on end + end + end + device pci 1f.3 on end # Intel HDA + device pci 1c.7 on + chip drivers/wifi/generic + register "wake" = "GPE0_DW2_03" + register "maxsleep" = "3" + device pci 00.0 on end + end + end # PCI Express Root Port 8 - WLAN end end
Ren Kuo has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add deivces settings ......................................................................
mb/google/dedede/var/magolor: Add deivces settings
Add the configuration in device tree: 1. Add HDA,sepacker codec and speaker amp setting 2. set the NC usb ports 3. Add Elan and Goodix touchscreen setting 4. Add facing camera usb setting 5. Add BT usb setting 6. Add Synaptics and Elan Touchpad setting 7. Add discrete WiFi configuration
BUG=None BRANCH=None TEST=build magolor firmware.
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: Ifc562b4a05c8955d2aec105f2f429f926ad1e702 --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 109 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/44633/2
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add deivces settings ......................................................................
Patch Set 2: Code-Review+1
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add deivces settings ......................................................................
Patch Set 2: Code-Review+1
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add deivces settings ......................................................................
Patch Set 2: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add deivces settings ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44633/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44633/2//COMMIT_MSG@7 PS2, Line 7: deivces device
https://review.coreboot.org/c/coreboot/+/44633/2//COMMIT_MSG@10 PS2, Line 10: HDA,sepacker HDA, speaker
https://review.coreboot.org/c/coreboot/+/44633/2//COMMIT_MSG@13 PS2, Line 13: facing world facing?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add deivces settings ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44633/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44633/2/src/mainboard/google/dedede... PS2, Line 54: chip drivers/usb/acpi : register "desc" = ""Integrated Bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H19)" : device usb 2.7 on end : end This is already present in baseboard/devicetree.cb. Is this required here again?
Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Paul Fagerburg, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44633
to look at the new patch set (#3).
Change subject: mb/google/dedede/var/magolor: Add device settings ......................................................................
mb/google/dedede/var/magolor: Add device settings
Add the configuration in device tree: 1. Add HDA,sepacker codec and speaker amp setting 2. set the NC usb ports 3. Add Elan and Goodix touchscreen setting 4. Add facing camera usb setting 5. Add BT usb setting 6. Add Synaptics and Elan Touchpad setting 7. Add discrete WiFi configuration
BUG=None BRANCH=None TEST=build magolor firmware.
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: Ifc562b4a05c8955d2aec105f2f429f926ad1e702 --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 109 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/44633/3
Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Paul Fagerburg, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44633
to look at the new patch set (#4).
Change subject: mb/google/dedede/var/magolor: Add device settings ......................................................................
mb/google/dedede/var/magolor: Add device settings
Add the configuration in device tree: 1. Add HDA, speaker codec and speaker amp setting 2. set the NC usb ports 3. Add Elan and Goodix touchscreen setting 4. Add facing camera usb setting 5. Add BT usb setting 6. Add Synaptics and Elan Touchpad setting 7. Add discrete WiFi configuration
BUG=None BRANCH=None TEST=build magolor firmware.
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: Ifc562b4a05c8955d2aec105f2f429f926ad1e702 --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 109 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/44633/4
Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Paul Fagerburg, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44633
to look at the new patch set (#5).
Change subject: mb/google/dedede/var/magolor: Add device settings ......................................................................
mb/google/dedede/var/magolor: Add device settings
Add the configuration in device tree: 1. Add HDA, speaker codec and speaker amp setting 2. set the NC usb ports 3. Add Elan and Goodix touchscreen setting 4. Add user facing camera usb setting 5. Add BT usb setting 6. Add Synaptics and Elan Touchpad setting 7. Add discrete WiFi configuration
BUG=None BRANCH=None TEST=build magolor firmware.
Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Change-Id: Ifc562b4a05c8955d2aec105f2f429f926ad1e702 --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 109 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/44633/5
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add device settings ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/44633/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44633/2//COMMIT_MSG@7 PS2, Line 7: deivces
device
Done
https://review.coreboot.org/c/coreboot/+/44633/2//COMMIT_MSG@10 PS2, Line 10: HDA,sepacker
HDA, speaker
Done
https://review.coreboot.org/c/coreboot/+/44633/2//COMMIT_MSG@13 PS2, Line 13: facing
world facing?
user facing
https://review.coreboot.org/c/coreboot/+/44633/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/magolor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44633/2/src/mainboard/google/dedede... PS2, Line 54: chip drivers/usb/acpi : register "desc" = ""Integrated Bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H19)" : device usb 2.7 on end : end
This is already present in baseboard/devicetree.cb. […]
OK. I will remove it!
Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Paul Fagerburg, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44633
to look at the new patch set (#6).
Change subject: mb/google/dedede/var/magolor: Add deivce settings ......................................................................
mb/google/dedede/var/magolor: Add deivce settings
Add the configuration in device tree: 1. Add HDA,speaker codec and speaker amp setting 2. set the NC usb ports 3. Add Elan and Goodix touchscreen setting 4. Add user facing camera usb setting 5. Add BT usb setting 6. Add Synaptics and Elan Touchpad setting 7. Add discrete WiFi configuration
BUG=None BRANCH=None TEST=build magolor firmware.
Change-Id: Ifc562b4a05c8955d2aec105f2f429f926ad1e702 --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 101 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/44633/6
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add deivce settings ......................................................................
Patch Set 6: Code-Review+1
Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Paul Fagerburg, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44633
to look at the new patch set (#7).
Change subject: mb/google/dedede/var/magolor: Add device settings ......................................................................
mb/google/dedede/var/magolor: Add device settings
Add the configuration in device tree: 1. Add HDA,speaker codec and speaker amp setting 2. Add Elan and Goodix touchscreen setting 3. Add user facing camera usb setting 4. Add BT usb setting 5. Add Synaptics and Elan Touchpad setting 6. Add discrete WiFi configuration
BUG=None BRANCH=None TEST=build magolor firmware.
Change-Id: Ifc562b4a05c8955d2aec105f2f429f926ad1e702 --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 101 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/44633/7
Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Paul Fagerburg, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44633
to look at the new patch set (#8).
Change subject: mb/google/dedede/var/magolor: Add device settings ......................................................................
mb/google/dedede/var/magolor: Add device settings
Add the configuration in device tree: 1. Add HDA,speaker codec and speaker amp setting 2. Add Elan and Goodix touchscreen setting 3. Add user facing camera usb setting 4. Add BT usb setting 5. Add Synaptics and Elan Touchpad setting 6. Add discrete WiFi configuration
BUG=None BRANCH=None TEST=build magolor firmware.
Change-Id: Ifc562b4a05c8955d2aec105f2f429f926ad1e702 Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 101 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/44633/8
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add device settings ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44633/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44633/8//COMMIT_MSG@13 PS8, Line 13: 4. Add BT usb setting I am not seeing it. I see only USB camera configuration.
https://review.coreboot.org/c/coreboot/+/44633/8//COMMIT_MSG@15 PS8, Line 15: 6. Add discrete WiFi configuration Is Magolor using discrete WiFi i.e. Realtek's Wifi?
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add device settings ......................................................................
Patch Set 8:
Also remove your +1. Since you are the author, you are not expected to +1 your changes.
Hello build bot (Jenkins), Furquan Shaikh, Henry Sun, Paul Fagerburg, Marco Chen, Paul Fagerburg, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44633
to look at the new patch set (#9).
Change subject: mb/google/dedede/var/magolor: Add device settings ......................................................................
mb/google/dedede/var/magolor: Add device settings
Add the configuration in device tree: 1. Add HDA,speaker codec and speaker amp setting 2. Add Elan and Goodix touchscreen setting 3. Add user facing camera usb setting 4 Add Synaptics and Elan Touchpad setting 5. Add WiFi configuration
BUG=None BRANCH=None TEST=build magolor firmware
Change-Id: Ifc562b4a05c8955d2aec105f2f429f926ad1e702 Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 101 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/44633/9
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add device settings ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44633/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44633/8//COMMIT_MSG@13 PS8, Line 13: 4. Add BT usb setting
I am not seeing it. I see only USB camera configuration.
Done
https://review.coreboot.org/c/coreboot/+/44633/8//COMMIT_MSG@15 PS8, Line 15: 6. Add discrete WiFi configuration
Is Magolor using discrete WiFi i.e. […]
Done
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add device settings ......................................................................
Patch Set 9: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add device settings ......................................................................
Patch Set 9: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add device settings ......................................................................
mb/google/dedede/var/magolor: Add device settings
Add the configuration in device tree: 1. Add HDA,speaker codec and speaker amp setting 2. Add Elan and Goodix touchscreen setting 3. Add user facing camera usb setting 4 Add Synaptics and Elan Touchpad setting 5. Add WiFi configuration
BUG=None BRANCH=None TEST=build magolor firmware
Change-Id: Ifc562b4a05c8955d2aec105f2f429f926ad1e702 Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44633 Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/magolor/overridetree.cb 1 file changed, 101 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Ren Kuo: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/magolor/overridetree.cb b/src/mainboard/google/dedede/variants/magolor/overridetree.cb index 404024b..630919f 100644 --- a/src/mainboard/google/dedede/variants/magolor/overridetree.cb +++ b/src/mainboard/google/dedede/variants/magolor/overridetree.cb @@ -1,5 +1,8 @@ chip soc/intel/jasperlake
+ # USB Port Configuration + register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # Camera + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | @@ -9,10 +12,11 @@ #| | for TPM communication | #| | before memory is up | #| I2C0 | Trackpad | - #| I2C1 | Digitizer | + #| I2C1 | TBD | #| I2C2 | Touchscreen | #| I2C3 | Camera | #| I2C4 | Audio | + #| I2C5 | TBD | #+-------------------+---------------------------+ register "common_soc_config" = "{ .gspi[0] = { @@ -37,6 +41,101 @@ }"
device domain 0 on - device pci 15.0 on end + device pci 14.0 on + chip drivers/usb/acpi + device usb 0.0 on + chip drivers/usb/acpi + register "desc" = ""Camera"" + register "type" = "UPC_TYPE_INTERNAL" + device usb 2.5 on end + end + end + end + end # USB xHCI + device pci 15.0 on + chip drivers/i2c/hid + register "generic.hid" = ""PNP0C50"" + register "generic.desc" = ""Synaptics Touchpad"" + register "generic.irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" + register "generic.wake" = "GPE0_DW0_03" + register "generic.probed" = "1" + register "hid_desc_reg_offset" = "0x20" + device i2c 0x2c on end + end + chip drivers/i2c/generic + register "hid" = ""ELAN0000"" + register "desc" = ""ELAN Touchpad"" + register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)" + register "wake" = "GPE0_DW0_03" + register "probed" = "1" + device i2c 15 on end + end + end # I2C 0 + device pci 15.2 on + chip drivers/i2c/hid + register "generic.hid" = ""GDIX0000"" + register "generic.desc" = ""Goodix Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "2" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "generic.enable_delay_ms" = "12" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 0x5d on end + end + chip drivers/i2c/hid + register "generic.hid" = ""ELAN9050"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D4_IRQ)" + register "generic.probed" = "1" + register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" + register "generic.reset_delay_ms" = "20" + register "generic.reset_off_delay_ms" = "2" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)" + register "generic.stop_delay_ms" = "280" + register "generic.stop_off_delay_ms" = "2" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" + register "generic.enable_delay_ms" = "1" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 10 on end + end + end # I2C 2 + device pci 19.0 on + chip drivers/i2c/generic + register "hid" = ""10EC5682"" + register "name" = ""RT58"" + register "desc" = ""Realtek RT5682"" + register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_D16)" + register "property_count" = "1" + register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" + register "property_list[0].name" = ""realtek,jd-src"" + register "property_list[0].integer" = "1" + device i2c 1a on end + end + chip drivers/i2c/generic + register "hid" = ""10EC1015"" + register "desc" = ""Realtek SPK AMP L"" + register "uid" = "0" + device i2c 28 on end + end + chip drivers/i2c/generic + register "hid" = ""10EC1015"" + register "desc" = ""Realtek SPK AMP R"" + register "uid" = "1" + device i2c 29 on end + end + end + device pci 1f.3 on end # Intel HDA + device pci 1c.7 on + chip drivers/wifi/generic + register "wake" = "GPE0_DW2_03" + register "maxsleep" = "3" + device pci 00.0 on end + end + end # PCI Express Root Port 8 - WLAN end end
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44633 )
Change subject: mb/google/dedede/var/magolor: Add device settings ......................................................................
Patch Set 10:
Automatic boot test returned (PASS/FAIL/TOTAL): 5/2/7 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/16420 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16419 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16418 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/16417 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/16416 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : FAIL : https://lava.9esec.io/r/16422 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/16421
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Furquan Shaikh (Code Review)
-
Henry Sun (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)
-
Paul Menzel (Code Review)
-
Ren Kuo (Code Review)