Attention is currently required from: Mario Scheithauer.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69382 )
Change subject: src/device: Add MDIO operation ......................................................................
Patch Set 1:
(3 comments)
File src/device/mdio.c:
https://review.coreboot.org/c/coreboot/+/69382/comment/7c8e214e_cf99236b PS1, Line 11: operations. Please add a '\n' here for a proper line break.
https://review.coreboot.org/c/coreboot/+/69382/comment/35371aea_984f6ff5 PS1, Line 11: mdio Shall we spell it upper case in log messages?
File src/include/device/mdio.h:
https://review.coreboot.org/c/coreboot/+/69382/comment/175683fd_11f58fcb PS1, Line 6: struct device; You should include <device/device.h> here and avoid the forward declaration of 'struct device' In addition, include <stdint.h> to provide types for uint*_t.